Skip to content

Add wasm rule to shared config #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

Add wasm rule to shared config #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb1d17
Add wasm rule to shared config
bennetthardwick Aug 22, 2025
76ed7be
fix lint
bennetthardwick Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-foxglove-extension",
"version": "1.0.5",
"version": "1.0.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future FYI - we don't bump versions on feature PRs. We do that separately so that no one feature PR decides the version bump.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my bad 👍🏻

"publisher": "foxglove",
"description": "Create and package Foxglove extensions",
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ export async function buildCommand(options: BuildOptions = {}): Promise<void> {
function getErrorOutput(compilation: webpack.Compilation): string {
const warnings = compilation
.getWarnings()
.map((warning) => String(warning.message))
.map((warning) => warning.message)
.join("\n");
const errors = compilation
.getErrors()
.map((error) => String(error.message))
.map((error) => error.message)
.join("\n");
let output = "";
if (warnings.length > 0) {
Expand Down
4 changes: 4 additions & 0 deletions src/webpackConfigExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ export default (
test: /\.css$/i,
use: ["style-loader", "css-loader"],
},
{
test: /\.wasm$/i,
type: "asset/inline",
},
],
},
plugins: [new CleanWebpackPlugin()],
Expand Down
Loading
Loading