Add missing response_handler tests

Author: frankroeder

tests/parrot/response_handler_spec.lua

@@ -16,8 +16,25 @@ describe("ResponseHandler", function()
         nvim_buf_set_lines = stub.new(),
         nvim_buf_add_highlight = stub.new(),
         nvim_win_get_cursor = stub.new().returns({ 1, 0 }),
+        nvim_set_hl = stub.new(),
+        nvim_buf_clear_namespace = stub.new(),
+        nvim_buf_line_count = stub.new().returns(10),
+        nvim_win_is_valid = stub.new().returns(true),
       },
       split = stub.new().returns({ "test" }),
+      list_slice = stub.new().returns({ "test" }),
+      tbl_map = stub.new().returns({ "test" }),
+      loop = {
+        new_timer = stub.new().returns({
+          start = stub.new(),
+          stop = stub.new(),
+          close = stub.new(),
+        }),
+        hrtime = stub.new().returns(1000000000), -- 1 second in nanoseconds
+      },
+      schedule_wrap = function(fn)
+        return fn
+      end,
       -- Remove vim.cmd to avoid potential issues with Vim options
     }
 
@@ -31,14 +48,21 @@ describe("ResponseHandler", function()
       get = stub.new().returns({ ns_id = 1, ex_id = 1 }),
     }
 
+    -- Mock logger module
+    local mock_logger = {
+      debug = stub.new(),
+    }
+
     -- Use package.loaded instead of _G.vim
     package.loaded.vim = mock_vim
     package.loaded["parrot.utils"] = mock_utils
+    package.loaded["parrot.logger"] = mock_logger
   end)
 
   after_each(function()
     package.loaded.vim = nil
     package.loaded["parrot.utils"] = nil
+    package.loaded["parrot.logger"] = nil
   end)
 
   it("should create a new ResponseHandler with default values", function()
@@ -80,7 +104,6 @@ describe("ResponseHandler", function()
     assert.are.same("", handler.response)
   end)
 
-
   it("should not move the cursor when cursor is false", function()
     local handler = ResponseHandler:new(mock_queries)
     handler.response = "line1\nline2"
@@ -93,4 +116,159 @@ describe("ResponseHandler", function()
     local handler_func = handler:create_handler()
     assert.is_function(handler_func)
   end)
+
+  it("should schedule updates with timer", function()
+    local handler = ResponseHandler:new(mock_queries)
+    local mock_timer = {
+      start = stub.new(),
+      stop = stub.new(),
+      close = stub.new(),
+    }
+
+    -- Mock vim.loop.new_timer
+    local original_new_timer = vim.loop.new_timer
+    vim.loop.new_timer = stub.new().returns(mock_timer)
+
+    handler:schedule_update(1)
+
+    assert.stub(vim.loop.new_timer).was_called()
+    assert.stub(mock_timer.start).was_called()
+
+    -- Restore original function
+    vim.loop.new_timer = original_new_timer
+  end)
+
+  it("should flush updates to buffer", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.response = "test response"
+    handler.pending_chunks = true
+    handler.first_line = 1
+    handler.finished_lines = 0
+
+    -- Setup fresh mocks for this test
+    mock_queries.get.returns({ ns_id = 1, ex_id = 1, response = "" })
+    mock_vim.split.returns({ "test response" })
+    mock_vim.api.nvim_buf_get_extmark_by_id.returns({ 1, 0 })
+    mock_vim.api.nvim_buf_is_valid.returns(true)
+
+    handler:flush_updates(1)
+
+    -- Test behavior rather than implementation
+    assert.are.same(false, handler.pending_chunks)
+    assert.are.same("", handler.chunk_buffer)
+  end)
+
+  it("should update buffer with response lines", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.response = "line1\nline2\nline3"
+    handler.first_line = 1
+    handler.finished_lines = 0
+
+    -- Setup mocks for this test
+    mock_vim.split.returns({ "line1", "line2", "line3" })
+    mock_vim.tbl_map.returns({ "line1", "line2", "line3" })
+    mock_vim.list_slice.returns({ "line1", "line2", "line3" })
+
+    -- Call the method - we can't easily test the vim API calls due to mocking complexity
+    -- but we can test that the method doesn't crash
+    handler:update_buffer()
+
+    -- Test that state is maintained
+    assert.are.same("line1\nline2\nline3", handler.response)
+    assert.are.same(1, handler.first_line)
+  end)
+
+  it("should update highlighting for new lines", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.response = "line1\nline2\nline3"
+    handler.first_line = 1
+    handler.finished_lines = 0
+
+    -- Setup mocks for this test
+    mock_vim.split.returns({ "line1", "line2", "line3" })
+
+    local qt = { ns_id = 1 }
+    handler:update_highlighting(qt)
+
+    -- Test that finished_lines is updated correctly
+    assert.are.same(2, handler.finished_lines)
+  end)
+
+  it("should update query object with line information", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.response = "line1\nline2\nline3"
+    handler.first_line = 1
+
+    -- Mock vim.split to return the lines
+    mock_vim.split.returns({ "line1", "line2", "line3" })
+
+    local qt = {}
+    handler:update_query_object(qt)
+
+    assert.are.same(1, qt.first_line)
+    assert.are.same(3, qt.last_line)
+  end)
+
+  it("should move cursor when cursor is true", function()
+    local handler = ResponseHandler:new(mock_queries, nil, 1, 1, true, "", true)
+    handler.response = "line1\nline2"
+    handler.first_line = 1
+
+    -- Setup mocks for this test
+    mock_vim.split.returns({ "line1", "line2" })
+
+    handler:move_cursor()
+
+    -- Test that cursor property is maintained
+    assert.are.same(true, handler.cursor)
+    assert.are.same(1, handler.first_line)
+  end)
+
+  it("should cleanup timers properly", function()
+    local handler = ResponseHandler:new(mock_queries)
+    local mock_timer = {
+      stop = stub.new(),
+      close = stub.new(),
+    }
+    handler.update_timer = mock_timer
+
+    handler:cleanup()
+
+    assert.stub(mock_timer.stop).was_called()
+    assert.stub(mock_timer.close).was_called()
+    assert.is_nil(handler.update_timer)
+  end)
+
+  it("should not update buffer when first_line is nil", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.first_line = nil
+    handler.response = "test"
+
+    handler:update_buffer()
+
+    assert.stub(mock_vim.api.nvim_buf_set_lines).was_not_called()
+  end)
+
+  it("should not update highlighting when first_line is nil", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.first_line = nil
+    handler.response = "test"
+
+    local qt = { ns_id = 1 }
+    handler:update_highlighting(qt)
+
+    assert.stub(mock_vim.api.nvim_buf_clear_namespace).was_not_called()
+  end)
+
+  it("should not update query object when first_line is nil", function()
+    local handler = ResponseHandler:new(mock_queries)
+    handler.first_line = nil
+    handler.response = "test"
+
+    local qt = {}
+    handler:update_query_object(qt)
+
+    assert.is_nil(qt.first_line)
+    assert.is_nil(qt.last_line)
+  end)
 end)