Skip to content

fix: 🐛 don't apply ellipsis to checkbox column #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prssanna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 🐛 don't apply ellipsis to checkbox column #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/cellmanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,18 +768,21 @@ export default class CellManager {
isFilter,
isTotalRow
} = cell;

const dataAttr = makeDataAttributeString({
rowIndex,
colIndex,
isHeader,
isFilter,
isTotalRow
isTotalRow,
});

const row = this.datamanager.getRow(rowIndex);

const isBodyCell = !(isHeader || isFilter || isTotalRow);

const isCheckboxCell = Boolean(cell.column && cell.column.id == '_checkbox');

const className = [
'dt-cell',
'dt-cell--col-' + colIndex,
Expand All @@ -788,7 +791,8 @@ export default class CellManager {
isHeader ? 'dt-cell--header' : '',
isHeader ? `dt-cell--header-${colIndex}` : '',
isFilter ? 'dt-cell--filter' : '',
isBodyCell && (row && row.meta.isTreeNodeClose) ? 'dt-cell--tree-close' : ''
isBodyCell && (row && row.meta.isTreeNodeClose) ? 'dt-cell--tree-close' : '',
isCheckboxCell ? 'dt-cell--checkbox': '',
].join(' ');

return `
Expand Down
4 changes: 4 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@
&:last-child {
border-right: 1px solid var(--dt-border-color);
}

&--checkbox &__content {
text-overflow: clip;
}
}

.icon-open, .icon-close {
Expand Down