Reimplement BMP

[jenstornell]

[peter279k]

Just note that this image format requirement should be let this package require php-7.2 version at least.

You can refer the imagebmp function reference.

[peter279k]

I want to know why the imagebmp function should require php-7.2 version.

And I saw that it should require php-7.1 version.

I just have the test inside a new Docker container and it looks fine when I call imagebmp function from php-7.1 version.

Instruction

Here is the Dockerfile I create to build the php-7.1 container.

# Install required packages

FROM ubuntu:16.04
RUN apt-get update
RUN apt-get install -y software-properties-common
RUN apt-get install -y python-software-properties
RUN LC_ALL=C.UTF-8 add-apt-repository -y ppa:ondrej/php
RUN apt-get update
RUN apt-get install -y apt-transport-https apt-utils curl php7.1-cli php7.1-mysql php7.1-curl php7.1-gd
RUN apt-get install -y libcurl3-openssl-dev

ENTRYPOINT [ "bash" ]

After building this container successfully, try entering to this container via interactive shell.

And the final result is as follows:

When I use the php-7.2 version, it looks fine finally.

Here is the Dockerfile for building php-7.2.

Here is the `Dockerfile` I create to build the `php-7.1` container.

```bash
# Install required packages

FROM ubuntu:16.04
RUN apt-get update
RUN apt-get install -y software-properties-common
RUN apt-get install -y python-software-properties
RUN LC_ALL=C.UTF-8 add-apt-repository -y ppa:ondrej/php
RUN apt-get update
RUN apt-get install -y apt-transport-https apt-utils curl php7.2-cli php7.2-mysql php7.2-curl php7.2-gd
RUN apt-get install -y libcurl3-openssl-dev

ENTRYPOINT [ "bash" ]

[jenstornell]

Nice research!

Version 7.2.0 was released 30 Nov 2017. I don't have a problem with having 7.2 as requirement, not personally anyway.

I've not tested it, but if the rest of the formats still work without crashing the whole thing below 7.2 we could have a mixed requirement, something like below?

Requirements

• PHP 7.0 - gif, jpg and png supported
• PHP 7.1 - webp supported
• PHP 7.2 - bmp supported

...or add exceptions to throw errors on old versions with unsupported formats.

[peter279k]

@jenstornell, actually, the imagewebp will be supported on php-7.0+ version :).