-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update and complete README-PL #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updating and completing translation into PL
README-PL.md
Outdated
|
||
**Zawartość** | ||
**Spis treści** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the content below just links? don't really see how it's a spis treści
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, it's still WIP, original Zawartość is good, I can revert
Let me know if you disagree with anything else, happy to change back, a lot of it preferential
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, could you please review and let me know if you don't agree with anything?
I've added some content based on the English source file.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, give me a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for the review, well spotted errors :) It's always good to have a second pair of eyes.
This is my first time contributing to open source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you happy to approve the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have write access 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, I have commented for maintainers to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the issues i mentioned
also let me know if i can improve my reviewing, first time doing this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hello @maintainers, would you be able to review this PR? Is there anything else needed to merge? Thank you |
Checklist:
I have noticed that the Polish translation is incomplete. I would like to complete the content and refine the existing translation.
Update index.md
)main
branch of freeCodeCamp.Closes #1029