Skip to content

Commit 61017db

Browse files
committed
document warnings. 1.21 release notes updates
1 parent 1670dc5 commit 61017db

8 files changed

+488
-574
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,3 @@ See [ReleaseNotes](docs/ReleaseNotes.md) for a full history.
6464
| | |
6565
| **Feature Requests** | |
6666
| none | none |
67-

docs/BuildingJacobFromSource.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ The simplest build environment includes MS Visual Studio 16.0 (Studio 2019), Ecl
6464
| 1.18 | VS 2013 (12) Windows SDK 7.1A | 1.6.0 (50) | 1.8.4 Eclipse Embedded | Eclipse 4.3 | 32 and 64 bit |
6565
| 1.19 | VS 2013 (12) Windows SDK 7.1A | 1.8.0 (52) | 1.10.1 Eclipse Provided | Eclipse 4.7 | 32 and 64 bit |
6666
| 1.20 | VS 2019 (16) Windows SDK 10 | 1.8.0 (52) | 1.10.8 Eclipse Provided | Eclipse 2020 09 | 32 and 64 bit |
67-
| 1.21 | VS 2022 (17) Windows SDK 11 10.0.22621.0 | 17 | VSCode provided | VSCode | 32 and 64 bit |
67+
| 1.21 | VS 2022 (17) Windows SDK 11 10.0.22621.0 | 1.8.0 (52) | VSCode provided | VSCode | 32 and 64 bit |
6868

6969
Microsoft Visual Studio 2019 supports 64 bit builds. so no additional tools are required.
7070

src/main/com/jacob/activeX/ActiveXComponent.java

Lines changed: 76 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ public class ActiveXComponent extends Dispatch {
4747
* This constructor causes a new Windows object of the requested type to be
4848
* created. The windows CoCreate() function gets called to create the
4949
* underlying windows object.
50-
*
50+
*
5151
* <pre>
5252
* new ActiveXComponent(&quot;ScriptControl&quot;);
5353
* </pre>
54-
*
55-
* @param programId
54+
*
55+
* @param programId the registry identifer for the target
5656
*/
5757
public ActiveXComponent(String programId) {
5858
super(programId);
@@ -62,16 +62,16 @@ public ActiveXComponent(String programId) {
6262
* Creates an active X component that is built on top of the COM pointers
6363
* held in the passed in dispatch. This widens the Dispatch object to pick
6464
* up the ActiveXComponent API
65-
*
66-
* @param dispatchToBeWrapped
65+
*
66+
* @param dispatchToBeWrapped - can wrap an ActiveXComponent around a dispatch
6767
*/
6868
public ActiveXComponent(Dispatch dispatchToBeWrapped) {
6969
super(dispatchToBeWrapped);
7070
}
7171

7272
/**
7373
* only used by the factories
74-
*
74+
*
7575
*/
7676
private ActiveXComponent() {
7777
super();
@@ -80,7 +80,7 @@ private ActiveXComponent() {
8080
/**
8181
* Probably was a cover for something else in the past. Should be
8282
* deprecated.
83-
*
83+
*
8484
* @return Now it actually returns this exact same object.
8585
*/
8686
public Dispatch getObject() {
@@ -97,8 +97,8 @@ public Dispatch getObject() {
9797
* throws no exceptions and returns null on failure.
9898
* <p>
9999
* This will fail for any prog id with a ":" in it.
100-
*
101-
* @param pRequestedProgramId
100+
*
101+
* @param pRequestedProgramId the program id from the registry
102102
* @return Dispatch pointer to the COM object or null if couldn't create
103103
*/
104104
public static ActiveXComponent createNewInstance(String pRequestedProgramId) {
@@ -126,8 +126,8 @@ public static ActiveXComponent createNewInstance(String pRequestedProgramId) {
126126
* that it throws no exceptions and returns null on failure.
127127
* <p>
128128
* This will fail for any prog id with a ":" in it
129-
*
130-
* @param pRequestedProgramId
129+
*
130+
* @param pRequestedProgramId the regsistry program id
131131
* @return Dispatch pointer to a COM object or null if wasn't already
132132
* running
133133
*/
@@ -157,15 +157,15 @@ protected void finalize() {
157157

158158
/*
159159
* ============================================================
160-
*
160+
*
161161
* start of instance based calls to the COM layer
162162
* ===========================================================
163163
*/
164164

165165
/**
166166
* retrieves a property and returns it as a Variant
167-
*
168-
* @param propertyName
167+
*
168+
* @param propertyName the property name
169169
* @return variant value of property
170170
*/
171171
public Variant getProperty(String propertyName) {
@@ -174,8 +174,8 @@ public Variant getProperty(String propertyName) {
174174

175175
/**
176176
* retrieves a property and returns it as an ActiveX component
177-
*
178-
* @param propertyName
177+
*
178+
* @param propertyName the property name
179179
* @return Dispatch representing the object under the property name
180180
*/
181181
public ActiveXComponent getPropertyAsComponent(String propertyName) {
@@ -186,9 +186,9 @@ public ActiveXComponent getPropertyAsComponent(String propertyName) {
186186

187187
/**
188188
* retrieves a property and returns it as a Boolean
189-
*
190-
* @param propertyName
191-
* property we are looking up
189+
*
190+
* @param propertyName the property name
191+
* property we are looking up
192192
* @return boolean value of property
193193
*/
194194
public boolean getPropertyAsBoolean(String propertyName) {
@@ -197,9 +197,9 @@ public boolean getPropertyAsBoolean(String propertyName) {
197197

198198
/**
199199
* retrieves a property and returns it as a byte
200-
*
201-
* @param propertyName
202-
* property we are looking up
200+
*
201+
* @param propertyName the property name
202+
* property we are looking up
203203
* @return byte value of property
204204
*/
205205
public byte getPropertyAsByte(String propertyName) {
@@ -208,8 +208,8 @@ public byte getPropertyAsByte(String propertyName) {
208208

209209
/**
210210
* retrieves a property and returns it as a String
211-
*
212-
* @param propertyName
211+
*
212+
* @param propertyName the property name
213213
* @return String value of property
214214
*/
215215
public String getPropertyAsString(String propertyName) {
@@ -219,8 +219,8 @@ public String getPropertyAsString(String propertyName) {
219219

220220
/**
221221
* retrieves a property and returns it as a int
222-
*
223-
* @param propertyName
222+
*
223+
* @param propertyName the property name
224224
* @return the property value as an int
225225
*/
226226
public int getPropertyAsInt(String propertyName) {
@@ -229,66 +229,59 @@ public int getPropertyAsInt(String propertyName) {
229229

230230
/**
231231
* sets a property on this object
232-
*
233-
* @param propertyName
234-
* property name
235-
* @param arg
236-
* variant value to be set
232+
*
233+
* @param propertyName property name
234+
* @param arg variant value to be set
237235
*/
238236
public void setProperty(String propertyName, Variant arg) {
239237
Dispatch.put(this, propertyName, arg);
240238
}
241239

242240
/**
243241
* sets a property on this object
244-
*
245-
* @param propertyName
246-
* property name
247-
* @param arg
248-
* variant value to be set
242+
*
243+
* @param propertyName property name
244+
* @param arg variant value to be set
249245
*/
250246
public void setProperty(String propertyName, Dispatch arg) {
251247
Dispatch.put(this, propertyName, arg);
252248
}
253249

254250
/**
255251
* sets a property to be the value of the string
256-
*
257-
* @param propertyName
258-
* @param propertyValue
252+
*
253+
* @param propertyName the property name
254+
* @param propertyValue the new value
259255
*/
260256
public void setProperty(String propertyName, String propertyValue) {
261257
this.setProperty(propertyName, new Variant(propertyValue));
262258
}
263259

264260
/**
265261
* sets a property as a boolean value
266-
*
267-
* @param propertyName
268-
* @param propValue
269-
* the boolean value we want the prop set to
262+
*
263+
* @param propertyName the property name
264+
* @param propValue the boolean value we want the prop set to
270265
*/
271266
public void setProperty(String propertyName, boolean propValue) {
272267
this.setProperty(propertyName, new Variant(propValue));
273268
}
274269

275270
/**
276271
* sets a property as a boolean value
277-
*
278-
* @param propertyName
279-
* @param propValue
280-
* the boolean value we want the prop set to
272+
*
273+
* @param propertyName the property value
274+
* @param propValue the boolean value we want the prop set to
281275
*/
282276
public void setProperty(String propertyName, byte propValue) {
283277
this.setProperty(propertyName, new Variant(propValue));
284278
}
285279

286280
/**
287281
* sets the property as an int value
288-
*
289-
* @param propertyName
290-
* @param propValue
291-
* the int value we want the prop to be set to.
282+
*
283+
* @param propertyName the property name
284+
* @param propValue the int value we want the prop to be set to.
292285
*/
293286
public void setProperty(String propertyName, int propValue) {
294287
this.setProperty(propertyName, new Variant(propValue));
@@ -306,12 +299,10 @@ public void setProperty(String propertyName, int propValue) {
306299

307300
/**
308301
* used by the doc and application listeners to get intelligent logging
309-
*
310-
* @param description
311-
* event description
312-
* @param args
313-
* args passed in (variants)
314-
*
302+
*
303+
* @param description event description
304+
* @param args args passed in (variants)
305+
*
315306
*/
316307
public void logCallbackEvent(String description, Variant[] args) {
317308
String argString = "";
@@ -364,15 +355,15 @@ public void logCallbackEvent(String description, Variant[] args) {
364355

365356
/*
366357
* ==============================================================
367-
*
358+
*
368359
* covers for dispatch call methods
369360
* =============================================================
370361
*/
371362

372363
/**
373364
* makes a dispatch call for the passed in action and no parameter
374-
*
375-
* @param callAction
365+
*
366+
* @param callAction the action to be called
376367
* @return ActiveXComponent representing the results of the call
377368
*/
378369
public ActiveXComponent invokeGetComponent(String callAction) {
@@ -381,9 +372,9 @@ public ActiveXComponent invokeGetComponent(String callAction) {
381372

382373
/**
383374
* makes a dispatch call for the passed in action and single parameter
384-
*
385-
* @param callAction
386-
* @param parameters
375+
*
376+
* @param callAction the action to be passed in
377+
* @param parameters this looks plural..
387378
* @return ActiveXComponent representing the results of the call
388379
*/
389380
public ActiveXComponent invokeGetComponent(String callAction,
@@ -393,9 +384,9 @@ public ActiveXComponent invokeGetComponent(String callAction,
393384

394385
/**
395386
* invokes a single parameter call on this dispatch that returns no value
396-
*
397-
* @param actionCommand
398-
* @param parameter
387+
*
388+
* @param actionCommand the call name
389+
* @param parameter the String parameter
399390
* @return a Variant but that may be null for some calls
400391
*/
401392
public Variant invoke(String actionCommand, String parameter) {
@@ -405,9 +396,9 @@ public Variant invoke(String actionCommand, String parameter) {
405396
/**
406397
* makes a dispatch call to the passed in action with a single boolean
407398
* parameter
408-
*
409-
* @param actionCommand
410-
* @param parameter
399+
*
400+
* @param actionCommand the call name
401+
* @param parameter the boolean parameter
411402
* @return Variant result
412403
*/
413404
public Variant invoke(String actionCommand, boolean parameter) {
@@ -416,9 +407,9 @@ public Variant invoke(String actionCommand, boolean parameter) {
416407

417408
/**
418409
* makes a dispatch call to the passed in action with a single int parameter
419-
*
420-
* @param actionCommand
421-
* @param parameter
410+
*
411+
* @param actionCommand the command
412+
* @param parameter the int parameter
422413
* @return Variant result of the invoke (Dispatch.call)
423414
*/
424415
public Variant invoke(String actionCommand, int parameter) {
@@ -428,10 +419,10 @@ public Variant invoke(String actionCommand, int parameter) {
428419
/**
429420
* makes a dispatch call to the passed in action with a string and integer
430421
* parameter (this was put in for some application)
431-
*
432-
* @param actionCommand
433-
* @param parameter1
434-
* @param parameter2
422+
*
423+
* @param actionCommand command that requires a string and int vlaues
424+
* @param parameter1 the string parameter
425+
* @param parameter2 the int parameter
435426
* @return Variant result
436427
*/
437428
public Variant invoke(String actionCommand, String parameter1,
@@ -443,10 +434,10 @@ public Variant invoke(String actionCommand, String parameter1,
443434
/**
444435
* makes a dispatch call to the passed in action with two integer parameters
445436
* (this was put in for some application)
446-
*
447-
* @param actionCommand
448-
* @param parameter1
449-
* @param parameter2
437+
*
438+
* @param actionCommand the action that accepts 2 int parmaeters
439+
* @param parameter1 first of two int parameters
440+
* @param parameter2 the second of two int parameters
450441
* @return a Variant but that may be null for some calls
451442
*/
452443
public Variant invoke(String actionCommand, int parameter1, int parameter2) {
@@ -456,8 +447,8 @@ public Variant invoke(String actionCommand, int parameter1, int parameter2) {
456447

457448
/**
458449
* makes a dispatch call for the passed in action and no parameter
459-
*
460-
* @param callAction
450+
*
451+
* @param callAction action name that requires zero parameters
461452
* @return a Variant but that may be null for some calls
462453
*/
463454
public Variant invoke(String callAction) {
@@ -467,9 +458,9 @@ public Variant invoke(String callAction) {
467458
/**
468459
* This is really a cover for call(String,Variant[]) that should be
469460
* eliminated call with a variable number of args mainly used for quit.
470-
*
471-
* @param name
472-
* @param args
461+
*
462+
* @param name the name we are invoking
463+
* @param args a single arg
473464
* @return Variant returned by the invoke (Dispatch.callN)
474465
*/
475466
public Variant invoke(String name, Variant... args) {

0 commit comments

Comments
 (0)