Skip to content

Commit 4d334f0

Browse files
authored
Fix deprecated lazy_fixture imports (#1674)
* Fix deprecated lazy_fixture imports * Set fail-fast to false to detect errors in python versions only * Update deprecated np.NaN * Removing no longer needed test dependency
1 parent e039301 commit 4d334f0

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

.github/workflows/general.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
if: github.event_name != 'schedule' || github.repository_owner == 'frictionlessdata'
2020
runs-on: ubuntu-latest
2121
strategy:
22+
fail-fast: false
2223
matrix:
2324
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
2425
steps:

frictionless/formats/pandas/parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def write_row_stream(self, source: TableResource):
157157
# http://pandas.pydata.org/pandas-docs/stable/gotchas.html#support-for-integer-na
158158
if value is None and field.type in ("number", "integer"):
159159
fixed_types[field.name] = "number"
160-
value = np.NaN
160+
value = np.nan
161161
if field.name in source.schema.primary_key:
162162
index_values.append(value)
163163
else:

frictionless/indexer/__spec__/test_resource.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
11
import pytest
2+
from pytest_lazy_fixtures import lf
23

34
from frictionless import formats, platform
45
from frictionless.resources import TableResource
56

67
control = formats.sql.SqlControl(table="table")
78
fast_database_urls = [
8-
pytest.lazy_fixtures("sqlite_url"),
9-
pytest.lazy_fixtures("postgresql_url"),
9+
lf("sqlite_url"),
10+
lf("postgresql_url"),
1011
]
1112
database_urls = fast_database_urls + [
12-
pytest.lazy_fixtures("mysql_url"),
13+
lf("mysql_url"),
1314
]
1415
if platform.type != "windows":
1516
database_urls += [
16-
pytest.lazy_fixtures("duckdb_url"),
17+
lf("duckdb_url"),
1718
]
1819
pytestmark = pytest.mark.skipif(
1920
platform.type == "darwin" or platform.type == "windows",

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ dev = [
7171
"pytest-cov",
7272
"pytest-vcr",
7373
"pytest-mock",
74-
"pytest-only",
7574
"oauth2client",
7675
"requests-mock",
7776
"pytest-dotenv",

0 commit comments

Comments
 (0)