Fix 1633 unexpected key error with primary key in schema and 1635 unexpected missing label error when ignoring header case#1641

Merged

pierrecamilleri merged 62 commits intofrictionlessdata:mainfrom

amelie-rondot:Fix-1633-and-1635

Aug 30, 2024

Commits on Aug 30, 2024

TDD: add test case for ignore header case in validating resource with schema_sync option

amelie-rondot
authored and
pierrecamilleri
committed
TDD: solve new test case

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring test_schema

amelie-rondot
authored and
pierrecamilleri
committed
Linting: format files

amelie-rondot
authored and
pierrecamilleri
committed
TDD: add test case for missing label in tabular data and ignoring case: test fails

amelie-rondot
authored and
pierrecamilleri
committed
TDD: fix missing required field with 'header_case=False' dialect and 'schema_sync=True' options

amelie-rondot
authored and
pierrecamilleri
committed
Linting: format files and sort imports

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring test

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring test

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring removing missing required label from field info part in '__open_row_stream()' 'TableResource' method

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: WIP

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: WIP2

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring creating schema fields among labels when using 'schema_sync' 'Detector' option

amelie-rondot
authored and
pierrecamilleri
committed
Doc: docstring

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: remve useless lines

amelie-rondot
authored and
pierrecamilleri
committed
TDD: add test case for missing label in TableResource corresponding to a required field and primary key schema: test fails

amelie-rondot
authored and
pierrecamilleri
committed
TDD: fix unexpected key-error: test passes

amelie-rondot
authored and
pierrecamilleri
committed
TDD: add test case for missing label in TableRecource columns corresponding to a primary key schema: test fails

amelie-rondot
authored and
pierrecamilleri
committed
TDD: append PrimaryKeyError in case of missing label corresponding to primary key schema field: test passes

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring tests

amelie-rondot
authored and
pierrecamilleri
committed
TDD: add test case for insensitive case on label corresponding to primary key schema: test fails

amelie-rondot
authored and
pierrecamilleri
committed
TDD: fix case insentive with label corresponding to primary key: test passes

amelie-rondot
authored and
pierrecamilleri
committed
TDD: edit test_cases to expected beahoviour: expect only missing-label error when missing label corresponding to a schema primary key: test fails

amelie-rondot
authored and
pierrecamilleri
committed
TDD: fix expected behaviour: test passes

amelie-rondot
authored and
pierrecamilleri
committed
TDD: restore one tet case: test fails

amelie-rondot
authored and
pierrecamilleri
committed
WIP: isolate test case to fix

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: WIP

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: WIP2

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: introduce intermediary methods to create cells in case of primary key constraint and considering case-sensitivity

amelie-rondot
authored and
pierrecamilleri
committed
TDD: fix test case comment ignore_case test case: test passes

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring test

amelie-rondot
authored and
pierrecamilleri
committed
TDD: restore insensitive-case test case: test fails

amelie-rondot
authored and
pierrecamilleri
committed
TDD: fix ignore header case test case: test passes

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring tests

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring tests 2

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: introduce intermediary 'Dialect' methods to add missing primary key label to the schema fields

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: refactoring 'Dialect' methods recently introduced

amelie-rondot
authored and
pierrecamilleri
committed
TDD: add new test cases: test passes

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: remove useless lines

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: format file

amelie-rondot
authored and
pierrecamilleri
committed
Doc: docstring

amelie-rondot
authored and
pierrecamilleri
committed
Refactoring: remove incorrect doc

amelie-rondot
authored and
pierrecamilleri
committed
Refactoring: rename 'add_fields_to_schema_among_labels' method into 'rearrange_schema_fields_given_labels'

amelie-rondot
authored and
pierrecamilleri
committed
Refactoring: rename 'fields_mapped'and 'fields_map' agruments into 'fields_mapping'

amelie-rondot
authored and
pierrecamilleri
committed
Refactoring: introduce 'index_name' variable to factorize 'rearrange_schema_fields_given_labels' method

amelie-rondot
authored and
pierrecamilleri
committed
Refactoring: edit comment with appropriate vocabulary

amelie-rondot
and
pierrecamilleri
committed
Refacto: remove useless import

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: Fix signature 'primary_key_cells' method and remove useless 'type: ignore'

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: remove useless 'if match' condition

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: edit comment

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: rename 'expected_fields_names' into 'expected_field_names' variable

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: introduce new method field_is_required and remove 'primary_key_field_name_not_in_label' method

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: format files

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: fix pyright errors and remove 'type: ignore'

amelie-rondot
authored and
pierrecamilleri
committed
Refacto: remove useless assesment lines

amelie-rondot
authored and
pierrecamilleri
committed
documentation
pierrecamilleri
committed
refactorings
pierrecamilleri
committed
format
pierrecamilleri
committed
fixup! documentation
pierrecamilleri
committed
🔵 linting
pierrecamilleri
committed
🔵 renames
pierrecamilleri
committed
fix
pierrecamilleri
committed