Attach resource's data #274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small suggest to force the data to be attached to the package object rather than stay as path/url. I would find such a functionality quite useful to be able to work on the data directly, rather than having to read it from elsewhere several time.
This could also be implemented as a seperate function if you think it's better.
Or, is there another way to do that?
If you want to implement this, I'm not sure about
col_select = NULL. Maybe it should be a different value?Here is may implementation: https://github.com/Rafnuss/GeoLocatoR/blob/master/R/read_gldp.R#L25-L35. As you can see I depend on
frictionless:::get_resourceandfrictionless:::read_from_pathwhich is not allowed I think. Any alternative would be great!