Fix MediaGallery to display selected variant images #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to frontvibe#366 Update `MediaGallery` component to display both product and variant images, prioritizing the selected variant's images. * Import `useProductVariants` and `useSelectedVariant` hooks in `app/components/product/MediaGallery.tsx`. * Concatenate variant images with product images and remove duplicate images based on Shopify CDN file URL. * Modify `useSelectedVariant` hook in `app/hooks/useSelectedVariant.tsx` to include `images` field for the selected variant.
|
@vishwamartur is attempting to deploy a commit to the Frontvibe Team on Vercel. A member of the Team first needs to authorize it. |
thomasKn
force-pushed
the
main
branch
3 times, most recently
from
a066e71 to
7d12c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #366
Update
MediaGallerycomponent to display both product and variant images, prioritizing the selected variant's images.useProductVariantsanduseSelectedVarianthooks inapp/components/product/MediaGallery.tsx.useSelectedVarianthook inapp/hooks/useSelectedVariant.tsxto includeimagesfield for the selected variant.