Skip to content

Fix/security vulnerabilities #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix/security vulnerabilities #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab5f0e0
fix: 🐛 do not verify iat
jimmyloi Sep 1, 2021
f572f3a
fix: update dependencies to address security vulnerabilities
jahammo2 Aug 12, 2025
3d50f10
chore: add Gemfile.lock to version control
jahammo2 Aug 12, 2025
7493a8e
Revert "chore: add Gemfile.lock to version control"
jahammo2 Aug 12, 2025
bb8ccd8
fix: update httparty dependency constraint to allow versions < 1.0
jahammo2 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions firebase_id_token.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_development_dependency 'bundler', '~> 1.17', '>= 1.17.2'
spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.33'
spec.add_development_dependency 'rake', '~> 12.3', '>= 12.3.3'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'redcarpet', '~> 3.4', '>= 3.4.0'
Expand All @@ -32,6 +32,6 @@ Gem::Specification.new do |spec|

spec.add_runtime_dependency 'redis', '~> 4.0', '>= 4.0.1'
spec.add_runtime_dependency 'redis-namespace', '~> 1.6', '>= 1.6.0'
spec.add_dependency 'httparty', '~> 0.16', '>= 0.16.2'
spec.add_dependency 'httparty', '>= 0.20.0', '< 1.0'
spec.add_runtime_dependency 'jwt', '~> 2.1', '>= 2.1.0'
end
5 changes: 2 additions & 3 deletions lib/firebase_id_token/signature.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module FirebaseIdToken
class Signature
# Pre-default JWT algorithm parameters as recommended
# [here](https://goo.gl/uOK5Jx).
JWT_DEFAULTS = { algorithm: 'RS256', verify_iat: true }
JWT_DEFAULTS = { algorithm: 'RS256', verify_iat: false }

# Returns the decoded JWT hash payload of the Firebase ID Token if the
# signature in the token matches with one of the certificates downloaded
Expand Down Expand Up @@ -117,8 +117,7 @@ def authorized?(payload)
end

def still_valid?(payload)
payload['exp'].to_i > Time.now.to_i &&
payload['iat'].to_i <= Time.now.to_i
payload['exp'].to_i > Time.now.to_i
end

def issuer_authorized?(payload)
Expand Down