Cleanup warning noise (#630)

Author: gusty

docsrc/content/applicative-functors.fsx

@@ -78,6 +78,9 @@ A List functor can be thought of as a function which takes an integer index to r
 So, you can think of ``map`` on a List functor as composing a function:
 
 **)
+
+#nowarn "0025" // Incomplete pattern matches on this expression. For example, the value '3' may indicate a case not covered by the pattern(s)
+
 let listFunc = function 0 -> 1 | 1 -> 2 | 2 -> 3 // [1;2;3]
 let r01'' = map (fun x -> string (x + 10)) listFunc
 

docsrc/content/type-free.fsx

@@ -2,6 +2,9 @@
 // This block of code is omitted in the generated HTML documentation. Use 
 // it to define helpers that you do not want to show in the documentation.
 #r @"../../src/FSharpPlus/bin/Release/net8.0/FSharpPlus.dll"
+#nowarn "0040" // This and other recursive references to the object(s) being defined will be checked for initialization-soundness at runtime through the use of a delayed reference.
+               // This is because you are defining one or more recursive objects, rather than recursive functions.
+
 (**
 Free<'Functor<'T>, 'T>
 ======================
@@ -89,7 +92,7 @@ type Reservation = {
     Name : string
     Email : string
     Quantity : int }
-    with static member Create (Quantity, Date, Name, Email) = { Date = Date; Name = Name; Email = Email; Quantity = Quantity }
+    with static member Create (quantity, date, name, email) = { Date = date; Name = name; Email = email; Quantity = quantity }
 
 let readReservationRequest =
     curryN Reservation.Create

docsrc/content/type-seqt.fsx

@@ -3,6 +3,7 @@
 // it to define helpers that you do not want to show in the documentation.
 
 #r @"../../src/FSharpPlus/bin/Release/net8.0/FSharpPlus.dll"
+#nowarn "0044" // Suppress warning FS0044: This construct is deprecated. WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.
 
 // For some reason AsyncDownloadString is not found during doc build. The following is a dumb implementation just to make the compiler happy.
 // TODO find out why.

src/FSharpPlus.Docs/Samples/Learn You a Haskell.fsx

@@ -322,6 +322,8 @@ let addStuff4 =                                                          // 19
     State monad
    --------------------------------------------------*)
 
+#nowarn "0025" // Incomplete pattern matches on this expression. For example, the value '[]' may indicate a case not covered by the pattern(s)
+
 type Stack = List<int>
 
 let pop (x::xs) = (x,xs)

src/FSharpPlus.TypeLevel/FSharpPlus.TypeLevel.fsproj

@@ -7,6 +7,7 @@
     <Platforms>AnyCPU</Platforms>
     <LangVersion Condition=" '$(Configuration)' == 'Fable'">5.0</LangVersion>
     <DefineConstants Condition=" '$(Configuration)' == 'Fable'">$(DefineConstants);FABLE_COMPILER</DefineConstants>
+    <OtherFlags>--nowarn:0044 $(OtherFlags)</OtherFlags>
   </PropertyGroup>
 
   <ItemGroup>

src/FSharpPlus.TypeLevel/Providers/FSharpPlus.Providers.fsproj

@@ -11,7 +11,7 @@
     <AssemblyVersion>$(VersionPrefix).0</AssemblyVersion>
     <FileVersion>$(VersionPrefix).0</FileVersion>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <OtherFlags>--warnon:1182 $(OtherFlags)</OtherFlags>
+    <OtherFlags>--nowarn:0044 --warnon:1182 $(OtherFlags)</OtherFlags>
     <GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>

src/FSharpPlus/Control/Monad.fs

@@ -136,15 +136,15 @@ type Join =
             match v.TryGetValue (k)  with
             | true, v -> dct.Add (k, v)
             | _       -> ()
-        dct :> IDictionary<'Key, 'U>
+        dct :> IDictionary<'Key, 'Value>
 
     static member Join (x: IReadOnlyDictionary<_, IReadOnlyDictionary<_, _>>, [<Optional>]_output: IReadOnlyDictionary<'Key, 'Value>, [<Optional>]_mthd: Join) : IReadOnlyDictionary<'Key, 'Value> =
         let dct = Dictionary ()
         for KeyValue(k, v) in x do
             match v.TryGetValue (k)  with
             | true, v -> dct.Add (k, v)
             | _       -> ()
-        dct :> IReadOnlyDictionary<'Key, 'U>
+        dct :> IReadOnlyDictionary<'Key, 'Value>
 
     static member        Join (x: ResizeArray<ResizeArray<'T>> , [<Optional>]_output: ResizeArray<'T>        , [<Optional>]_mthd: Join) = ResizeArray (Seq.bind seq<_> x) : ResizeArray<'T> 
 

src/FSharpPlus/Data/NonEmptyList.fs

@@ -166,7 +166,7 @@ module NonEmptyList =
     /// <summary>Splits the list in head and tail.</summary>
     /// <param name="list">The input list.</param>
     /// <returns>A tuple with the head and the tail of the original list.</returns>
-    let unconsAsList ({ Head = x; Tail = xs } as list) = x, xs
+    let unconsAsList { Head = x; Tail = xs } = x, xs
 
     /// Returns the first element of a new non empty list. You can also use property nel.Head.
     let head {Head = x; Tail = _ } = x

tests/CSharpLib/CustomerId.cs

@@ -7,7 +7,9 @@ public struct CustomerId : IEquatable<CustomerId>, ICustomerId
         public long Value { get; }
         public CustomerId(long value) => this.Value = value;
         public static readonly CustomerId Empty = new CustomerId();
+#pragma warning disable CA2013 // Do not use ReferenceEquals with value types
         public bool Equals(CustomerId other) => !ReferenceEquals(null, other) && Equals(Value, other.Value);
+#pragma warning restore CA2013 // Do not use ReferenceEquals with value types
         public override bool Equals(object obj) => obj is CustomerId id && Equals(id);
         public override int GetHashCode() => Value.GetHashCode();
         public override string ToString() => Value.ToString();

tests/FSharpPlusFable.Tests/FSharpPlusFable.Tests.fsproj

@@ -7,6 +7,7 @@
     <DefineConstants Condition=" '$(Configuration)' == 'Fable'">$(DefineConstants);FABLE_COMPILER;FABLE_COMPILER_FAKE</DefineConstants>
     <DefineConstants Condition=" '$(Configuration)' == 'Fable4'">$(DefineConstants);FABLE_COMPILER;FABLE_COMPILER_4;FABLE_COMPILER_FAKE</DefineConstants>
     <TargetFramework>net8.0</TargetFramework>
+    <OtherFlags>--nowarn:3520 $(OtherFlags)</OtherFlags>
   </PropertyGroup>
 
 

tests/FSharpPlusFable.Tests/FSharpTests/General/Monoid.fs

@@ -56,6 +56,8 @@ let monoid = testList "Monoid" [
         let z = x |> map (Seq.singleton >>             dict                      >> map List.singleton) |> Seq.sum
         Assert.IsInstanceOf<Option< Dictionary<string,int list>>> (Some y)
         Assert.IsInstanceOf<Option<IDictionary<string,int list>>> (Some z)
+        #else
+        let _ = x // Avoid unused variable warning
         #endif
         SideEffects.reset ()
 

tests/FSharpPlusFable.Tests/FSharpTests/General/MonoidCompile.fs

@@ -78,6 +78,8 @@ let testCompile =
 
     #if !FABLE_COMPILER
     let mapAB = plus mapA mapB
+    #else
+    let _ = mapA, mapB  // avoid unused warning for mapA and mapB
     #endif
     #if !FABLE_COMPILER
     let _greeting1 = Async.RunSynchronously mapAB.[2]

tests/benchmarks/ExtensionsBenchmarks.fs

@@ -92,7 +92,7 @@ module ResultOldVersion =
 module ResultNewVersion =
 
     let sequence (t: seq<Result<int, string>>) : Result<int seq, string> =
-        let mutable accumulator = ArrayCollector<'T> ()
+        let mutable accumulator = ArrayCollector<_> ()
         let mutable error = None
         use e = t.GetEnumerator ()
         while e.MoveNext () && error.IsNone do