Skip to content

Feature Request: Align overwrite function signatures with default method definitions #328

@mohantejach

Description

@mohantejach

Thanks for the great logger library.

While reviewing the tslog codebase, I noticed that the overwrite functions such as formatMeta and addMeta do not receive the settings object, whereas the default implementations do.

I’m trying to implement custom overrides for these functions, but without access to settings it’s difficult to replicate or extend the behavior of the default methods.

Would it make sense for the overwrite functions to follow the same method signature as the default ones, including the settings parameter?

Examples :

addMeta vs _addMetaToLogObj

Image

formatMeta vs _prettyFormatLogObjMeta

Image

I’m happy to help and can open a pull request if this change sounds reasonable.

Thanks for considering this enhancement.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions