Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Commit d963b1c

Browse files
authored
Merge pull request #26 from fullstack-devops/bugfix/fix-entrypoint.sh-else
fix entrypoint.sh
2 parents 9ac8f49 + dc422af commit d963b1c

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ If you are using `docker` or `podman` the options and commands are basically the
5353

5454
Run registerd to an Organisation:
5555
```bash
56-
docker run -e GH_ORG=fullstack-devops -e GH_ACCESS_TOKEN=ghp_**** github-actions-runner:latest
56+
docker run -e GH_ORG=fullstack-devops -e GH_ACCESS_TOKEN=ghp_**** ghcr.io/fullstack-devops/github-actions-runner:latest-base
5757
```
5858

5959
Run registerd to an Organisation and Repo:
6060
```bash
61-
docker run -e GH_ORG=fullstack-devops -e GH_REPO=github-runner-testing -e GH_ACCESS_TOKEN=ghp_**** github-actions-runner:latest
61+
docker run -e GH_ORG=fullstack-devops -e GH_REPO=github-runner-testing -e GH_ACCESS_TOKEN=ghp_**** ghcr.io/fullstack-devops/github-actions-runner:latest-base
6262
```
6363

6464
> Replace the `ghp_****` with your own valid personal access token

images/base/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ ARG DEBIAN_FRONTEND=noninteractive
55
ARG PACKAGES="libffi-dev libicu-dev build-essential libssl-dev ca-certificates software-properties-common jq sed grep git curl wget zip python3-pip"
66

77
ENV USERNAME="runner"
8+
ENV USERID=1000
89
ENV UBUNTU_VERSION=20.04
910
ENV RUNNER_HOME="/home/${USERNAME}/runner"
1011

@@ -45,7 +46,7 @@ RUN export ARCH=$(/helper-scripts/translate-aarch.sh a-short) \
4546
WORKDIR /home/${USERNAME}/runner
4647

4748
# add a non-sudo user
48-
RUN useradd -m $USERNAME \
49+
RUN useradd -m -u $USERID $USERNAME \
4950
&& usermod -aG sudo $USERNAME \
5051
&& chown -R $USERNAME $GH_RUNNER_WORKDIR \
5152
&& chown -R $USERNAME $GH_KANIKO_WORKDIR \

images/base/helper-scripts/gh-entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ cleanup() {
6565
echo "Removing runner..."
6666
if [ ! -z "$RUNNER_TOKEN" ]; then
6767
readonly REG_TOKEN=$RUNNER_TOKEN
68-
else [ ! -z $GH_ACCESS_TOKEN ]; then
68+
elif [ ! -z $GH_ACCESS_TOKEN ]; then
6969
readonly REG_TOKEN=$(curl -s -X POST -H "Accept: application/vnd.github.v3+json" -H "Authorization: token $GH_ACCESS_TOKEN" $RUNNER_REG_TOKEN_URL | jq .token --raw-output)
7070
fi
7171
${RUNNER_HOME}/config.sh remove --token ${REG_TOKEN}

images/kaniko-sidecar/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM gcr.io/kaniko-project/executor:v1.8.0-debug
1+
FROM gcr.io/kaniko-project/executor:v1.8.1-debug
22

33
COPY kaniko-entrypoint.sh /kaniko/kaniko-entrypoint.sh
44
WORKDIR /

0 commit comments

Comments
 (0)