Add additional swipe mode - actions on swipe (i.e. Fleksy mode)#1898
Add additional swipe mode - actions on swipe (i.e. Fleksy mode)#1898ndom91 wants to merge 25 commits intofuto-org:masterfrom
Conversation
…ng thorugh next suggestions from next word
|
Really excited to see this merged. A UI suggestion: it's best to use radio buttons for mutually exclusive options. Maybe something like Swipe input
|
Yeah good shout - let me update this |
…s a misspelling of a dictionary word
…cent character (other than space)
… back up to non-dictionary words
|
@ndom91 hi! since it may take a while to be merged, would you mind sharing the APK for your branch? I’d love to use this feature and report any bugs, but no particular interest in installing the tools to build it :) |
|
@magvag no problem. Let me know if there's anything you think we should tweak. I've been daily-driving it since opening this PR and am pretty happy with it at this point. Recommended "Keyboard & Typing" settings to emulate Fleksy behaviour include:
Apk can be found on my gdrive here: https://drive.google.com/file/d/1U04Gr2siSExq_0H-rmcYY_TZK5RiWsXE/view?usp=sharing |
|
@ndom91 thanks! so far so good, will come back with feedback later! |
|
first bug! horizontal swiping on space bar should be a separate zone with its own triggers. right now both swiping and long pressing do not work as language switcher and cursor mover. edit: same goes for swipes from backspace, not sure it should be addressed. |
|
2: a swipe to the left removes spaces as a separate instance. e.g. "two words" will require 3 swipes to remove. 3: a swipe up to restore original spelling makes the cursor go wild. if you swipe up in the middle of some paragraph, the cursor ends up glued to the start of a next word. If you swipe in the end of that paragraph, cursor jumps to the next line. 4: swiping up past original spelling of the last word starts spamming next word suggestions (or is it the end of the list of autocorrection suggestions?) 5: currently the swipe to the left feels like "selecting a word manually and removing it". I can even see the blue highlighter and it feels rather slow on my low-ish end device. Would be easier to just reuse the logic under the "Backspace behaviour while holding or swiping: delete whole words" setting (will solve bug №2 as well) if you are feeling like making a whole new feature, an "Add/remove last word to personal dictionary" action PR would be terrific. Currently it's very cumbersome to add words to dictionary since it requires going into settings. And with this functionality it would be trivial to replicate Fleksy behaviour of adding or removing words to dictionary with a swipe up (bug №4) overall thanks for your marvellous contribution. if you need reproduction steps or videos, I'll be glad to make them |
If you look how Fleksy manages swipe corrections, you will see that it stores suggestions and original spelling for every word in a typed (in one session) text block, so if you move you cursor to another word, you will see its state and corrections. Having this type of structure is a fundamental change, might not be mergeable – but at the very least the swipe correction should be disabled if the word under/before it is not the target one |
|
Amazing, thanks for the detailed feedback! I'll try to knock some of the low hanging fruit ones out this week and come back with a more detailed response when I have a bit more time 🙏 |
SettingsRadiocomponent for this new settings section.Question:
KeyboardTextsTable.javachanges that seem to keep automatically happening? Can I ignore those? They seem to just be shifting things around in the file and not making any actual changes