Start using haptics

Author: LaurentTreguier

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/BasePresenter.kt

@@ -1,5 +1,7 @@
 package app.fyreplace.fyreplace.legacy.ui
 
+import android.os.Build
+import android.view.HapticFeedbackConstants
 import android.view.View
 import androidx.annotation.StringRes
 import com.google.android.material.snackbar.BaseTransientBottomBar
@@ -10,9 +12,40 @@ interface BasePresenter : ContextHolder {
 
     fun showBasicSnackbar(
         @StringRes message: Int,
-        @BaseTransientBottomBar.Duration duration: Int = Snackbar.LENGTH_LONG
+        @BaseTransientBottomBar.Duration duration: Int = Snackbar.LENGTH_LONG,
+        haptics: HapticType? = null
     ) {
         val rootView = rootView ?: return
         Snackbar.make(rootView, rootView.context.getString(message), duration).show()
+
+        if (haptics != null) {
+            rootView.provideHapticFeedback(haptics)
+        }
+    }
+
+    fun View.provideHapticFeedback(type: HapticType = HapticType.SIMPLE) {
+        performHapticFeedback(
+            when {
+                Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE -> when (type) {
+                    HapticType.TOGGLE_ON -> HapticFeedbackConstants.TOGGLE_ON
+                    HapticType.TOGGLE_OFF -> HapticFeedbackConstants.TOGGLE_OFF
+                    else -> HapticFeedbackConstants.CONFIRM
+                }
+
+                Build.VERSION.SDK_INT >= Build.VERSION_CODES.R -> HapticFeedbackConstants.CONFIRM
+                else -> HapticFeedbackConstants.VIRTUAL_KEY
+            }
+        )
+    }
+
+    fun View.provideHapticFeedback(positive: Boolean) = provideHapticFeedback(
+        if (positive) HapticType.TOGGLE_ON
+        else HapticType.TOGGLE_OFF
+    )
+
+    enum class HapticType {
+        TOGGLE_ON,
+        TOGGLE_OFF,
+        SIMPLE
     }
 }

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/fragments/FeedFragment.kt

@@ -105,6 +105,7 @@ class FeedFragment :
         launch {
             vm.vote(position, spread)
             adapter.remove(position)
+            view.provideHapticFeedback(positive = spread)
         }
     }
 

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/fragments/PostFragment.kt

@@ -26,6 +26,7 @@ import app.fyreplace.fyreplace.legacy.extensions.mainActivity
 import app.fyreplace.fyreplace.legacy.extensions.makePreview
 import app.fyreplace.fyreplace.legacy.extensions.makeShareIntent
 import app.fyreplace.fyreplace.legacy.grpc.p
+import app.fyreplace.fyreplace.legacy.ui.BasePresenter
 import app.fyreplace.fyreplace.legacy.ui.PrimaryActionStyle
 import app.fyreplace.fyreplace.legacy.ui.adapters.PostAdapter
 import app.fyreplace.fyreplace.legacy.ui.adapters.holders.ItemHolder
@@ -315,17 +316,16 @@ class PostFragment :
                 if (subscribed) PostWasSubscribedToEvent(preview)
                 else PostWasUnsubscribedFromEvent(preview)
             )
-            showBasicSnackbar(
-                if (subscribed) R.string.post_snackbar_subscribed
-                else R.string.post_snackbar_unsubscribed,
-                Snackbar.LENGTH_SHORT
-            )
+            bd.root.provideHapticFeedback(positive = subscribed)
         }
     }
 
     private suspend fun report() {
         vm.report()
-        showBasicSnackbar(R.string.post_report_success_message)
+        showBasicSnackbar(
+            R.string.post_report_success_message,
+            haptics = BasePresenter.HapticType.SIMPLE
+        )
     }
 
     private suspend fun delete() {
@@ -336,7 +336,10 @@ class PostFragment :
 
     private suspend fun reportComment(comment: Comment) {
         vm.reportComment(comment.id)
-        showBasicSnackbar(R.string.post_comment_report_success_message)
+        showBasicSnackbar(
+            R.string.post_comment_report_success_message,
+            haptics = BasePresenter.HapticType.SIMPLE
+        )
     }
 
     private suspend fun deleteComment(position: Int, comment: Comment) {

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/fragments/UserFragment.kt

@@ -22,6 +22,7 @@ import app.fyreplace.fyreplace.legacy.extensions.getUsername
 import app.fyreplace.fyreplace.legacy.extensions.setAvatar
 import app.fyreplace.fyreplace.legacy.extensions.setLinkifiedText
 import app.fyreplace.fyreplace.legacy.extensions.setupTransitions
+import app.fyreplace.fyreplace.legacy.ui.BasePresenter
 import app.fyreplace.fyreplace.legacy.ui.FailureHandler
 import app.fyreplace.fyreplace.legacy.viewmodels.CentralViewModel
 import app.fyreplace.fyreplace.legacy.viewmodels.Sentence
@@ -165,7 +166,10 @@ class UserFragment : DialogFragment(), FailureHandler {
     private fun report() = showChoiceAlert(R.string.user_report_title, null) {
         launch {
             vm.report()
-            showBasicSnackbar(R.string.user_report_success_message)
+            showBasicSnackbar(
+                R.string.user_report_success_message,
+                haptics = BasePresenter.HapticType.SIMPLE
+            )
         }
     }
 
@@ -194,7 +198,10 @@ class UserFragment : DialogFragment(), FailureHandler {
     }
 
     private fun finishBan() {
-        showBasicSnackbar(R.string.user_ban_success_message)
+        showBasicSnackbar(
+            R.string.user_ban_success_message,
+            haptics = BasePresenter.HapticType.SIMPLE
+        )
         bd.toolbar.menu.findItem(R.id.ban).isVisible = false
         em.post(UserWasBannedEvent(args.profile.v.toBuilder().setIsBanned(true).build()))
     }

app/src/legacy/res/values/strings.xml

@@ -192,8 +192,6 @@
     <string name="post_comment_delete_title">Delete this comment?</string>
     <string name="post_comment_delete_message">This action cannot be undone.</string>
     <string name="post_write_comment">Add comment</string>
-    <string name="post_snackbar_subscribed">Subscribed to new comments</string>
-    <string name="post_snackbar_unsubscribed">Unsubscribed from new comments</string>
     <string name="post_snackbar_comment_created">New comment from %1$s</string>
     <string name="post_snackbar_comment_created_action">See</string>
     <string name="post_error_not_found_title">Post not found</string>