fix(require-jsdoc) for publicOnly, check named export declarations appearing as assignments

refactoring(require-jsdoc): compare anonymous default found with node in case may ever differ in future

Author: brettz9

README.md

@@ -3673,6 +3673,25 @@ be checked by the rule.
 The following patterns are considered problems:
 
 ````js
+export var test = function () {
+
+};
+// Options: [{"publicOnly":true,"require":{"FunctionExpression":true}}]
+// Message: Missing JSDoc comment.
+
+function test () {
+
+}
+export var test2 = test;
+// Options: [{"publicOnly":true,"require":{"FunctionDeclaration":true}}]
+// Message: Missing JSDoc comment.
+
+export const test = () => {
+
+};
+// Options: [{"publicOnly":true,"require":{"ArrowFunctionExpression":true}}]
+// Message: Missing JSDoc comment.
+
 export default function () {}
 // Options: [{"publicOnly":{"cjs":false,"esm":true,"window":false},"require":{"FunctionDeclaration":true}}]
 // Message: Missing JSDoc comment.

src/exportParser.js

@@ -206,12 +206,17 @@ const initVariables = function (node, globals, opts) {
       }
     });
     break;
+  } case 'ExportNamedDeclaration': {
+    if (node.declaration) {
+      initVariables(node.declaration, globals, opts);
+    }
+    break;
   }
   }
 };
 
 // Populates variable maps using AST
-const mapVariables = function (node, globals, opt) {
+const mapVariables = function (node, globals, opt, isExport) {
   /* istanbul ignore next */
   const opts = opt || {};
   /* istanbul ignore next */
@@ -234,7 +239,10 @@ const mapVariables = function (node, globals, opt) {
   } case 'VariableDeclaration': {
     node.declarations.forEach((declaration) => {
       const isGlobal = opts.initWindow && node.kind === 'var' && globals.props.window;
-      createSymbol(declaration.id, globals, declaration.init, globals, isGlobal);
+      const symbol = createSymbol(declaration.id, globals, declaration.init, globals, isGlobal);
+      if (symbol && isExport) {
+        symbol.exported = true;
+      }
     });
     break;
   } case 'FunctionDeclaration': {
@@ -253,10 +261,14 @@ const mapVariables = function (node, globals, opt) {
     break;
   } case 'ExportNamedDeclaration': {
     if (node.declaration) {
-      const symbol = createSymbol(node.declaration, globals, node.declaration);
-      /* istanbul ignore next */
-      if (symbol) {
-        symbol.exported = true;
+      if (node.declaration.type === 'VariableDeclaration') {
+        mapVariables(node.declaration, globals, opts, true);
+      } else {
+        const symbol = createSymbol(node.declaration, globals, node.declaration);
+        /* istanbul ignore next */
+        if (symbol) {
+          symbol.exported = true;
+        }
       }
     }
     node.specifiers.forEach((specifier) => {
@@ -314,7 +326,7 @@ const findNode = function (node, block, cache) {
 };
 
 const findExportedNode = function (block, node, cache) {
-  if (block.ANONYMOUS_DEFAULT) {
+  if (block.ANONYMOUS_DEFAULT === node) {
     return true;
   }
   /* istanbul ignore next */

test/rules/assertions/requireJsdoc.js

@@ -4,6 +4,73 @@
 
 export default {
   invalid: [
+    {
+      code: `
+          export var test = function () {
+
+          };
+      `,
+      errors: [
+        {
+          message: 'Missing JSDoc comment.',
+          type: 'FunctionExpression'
+        }
+      ],
+      options: [{
+        publicOnly: true,
+        require: {
+          FunctionExpression: true
+        }
+      }],
+      parserOptions: {
+        sourceType: 'module'
+      }
+    },
+    {
+      code: `
+          function test () {
+
+          }
+          export var test2 = test;
+      `,
+      errors: [
+        {
+          message: 'Missing JSDoc comment.',
+          type: 'FunctionDeclaration'
+        }
+      ],
+      options: [{
+        publicOnly: true,
+        require: {
+          FunctionDeclaration: true
+        }
+      }],
+      parserOptions: {
+        sourceType: 'module'
+      }
+    },
+    {
+      code: `
+          export const test = () => {
+
+          };
+      `,
+      errors: [
+        {
+          message: 'Missing JSDoc comment.',
+          type: 'ArrowFunctionExpression'
+        }
+      ],
+      options: [{
+        publicOnly: true,
+        require: {
+          ArrowFunctionExpression: true
+        }
+      }],
+      parserOptions: {
+        sourceType: 'module'
+      }
+    },
     {
       code: `
         export default function () {}