fix(require-returns): Ensure that @returns {undefined} tags with return undefined are not reported

Author: brettz9

src/rules/requireReturns.js

@@ -65,8 +65,9 @@ export default iterateJsdoc(({
 
   // In case the code returns something, we expect a return value in JSDoc.
   const [tag] = tags;
-  if (!utils.hasDefinedTypeReturnTag(tag) && utils.hasReturnValue() ||
-    (typeof tag === 'undefined' || tag === null) && utils.isForceRequireReturn()
+  const missingReturnTag = typeof tag === 'undefined' || tag === null;
+  if (missingReturnTag &&
+    (utils.hasReturnValue() || utils.isForceRequireReturn())
   ) {
     report('Missing JSDoc @' + tagName + ' declaration.');
   }

test/rules/assertions/requireReturns.js

@@ -422,6 +422,70 @@ export default {
           forceRequireReturn: true
         }
       }
+    },
+    {
+      code: `
+          /**
+           * @returns {void}
+           */
+          function quux () {
+            return undefined;
+          }
+      `
+    },
+    {
+      code: `
+          /**
+           * @returns {void}
+           */
+          function quux () {
+            return undefined;
+          }
+      `,
+      settings: {
+        jsdoc: {
+          forceRequireReturn: true
+        }
+      }
+    },
+    {
+      code: `
+          /**
+           * @returns {void}
+           */
+          function quux () {
+            return;
+          }
+      `
+    },
+    {
+      code: `
+          /**
+           * @returns {void}
+           */
+          function quux () {
+          }
+      `,
+      settings: {
+        jsdoc: {
+          forceRequireReturn: true
+        }
+      }
+    },
+    {
+      code: `
+          /**
+           * @returns {void}
+           */
+          function quux () {
+            return;
+          }
+      `,
+      settings: {
+        jsdoc: {
+          forceRequireReturn: true
+        }
+      }
     }
   ]
 };