Skip to content

Commit cda6839

Browse files
committed
fix: avoid errors when tags not present or invalidTypes is empty
1 parent 76962d5 commit cda6839

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

src/iterateJsdoc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ const curryUtils = (
212212
};
213213

214214
utils.forEachTag = (tagName, arrayHandler) => {
215-
const matchingJsdocTags = _.filter(jsdoc.tags, {
215+
const matchingJsdocTags = _.filter(jsdoc.tags || [], {
216216
tag: tagName
217217
});
218218

src/rules/checkTagNames.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ export default iterateJsdoc(({
77
utils,
88
jsdocNode
99
}) => {
10+
if (!jsdoc.tags) {
11+
return;
12+
}
1013
jsdoc.tags.forEach((jsdocTag) => {
1114
if (utils.isValidTag(jsdocTag.tag)) {
1215
const preferredTagName = utils.getPreferredTagName(jsdocTag.tag);

src/rules/checkTypes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export default iterateJsdoc(({
106106
}
107107
});
108108

109-
if (invalidTypes) {
109+
if (invalidTypes.length) {
110110
const fixedType = publish(typeAst);
111111

112112
const tagName = jsdocTag.tag;

src/rules/noTypes.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import iterateJsdoc from '../iterateJsdoc';
22

33
export default iterateJsdoc(({
4-
jsdoc,
4+
utils,
55
report
66
}) => {
7-
const tags = jsdoc.tags.filter((tag) => {
7+
const tags = utils.filterTags((tag) => {
88
return ['param', 'arg', 'argument', 'returns', 'return'].includes(tag.tag);
99
});
1010
tags.forEach((tag) => {

src/rules/validTypes.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ export default iterateJsdoc(({
88
report,
99
utils
1010
}) => {
11+
if (!jsdoc.tags) {
12+
return;
13+
}
1114
jsdoc.tags.forEach((tag) => {
1215
const validTypeParsing = function (type) {
1316
try {

0 commit comments

Comments
 (0)