Add news screen to example #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palingheorghe
added
Status: Review Needed
Type: Enhancement
palingheorghe
requested changes
Aug 23, 2019
There was a problem hiding this comment.
Hi! <3
Thanks for your PR! This is great, you're doing a great job!
Some of the things look really weird even tho I did all the necessary steps to use this. I've installed your branch on a fresh copy of galio-examples and still got some warnings. Please check the review I've left below.
Thanks 🤙🏽🔥
|
@carmenmitru Could you provide some images of these screens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Screens :