Skip to content

specify bee (incremental) build cache directory environment variable #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

js-9
Copy link

@js-9 js-9 commented Jul 13, 2025

specify bee (incremental) build cache directory environment variable for windows docker run command and cache to Library directory
This PR can be considered as an initial proposal. I'd be happy to add an option for the unity-builder action to specify the directory in the parameters, it's just that I had a really hard time understanding how the windows runner directory layout works, and couldn't find the directory in the path that is supposed to be the default on windows.

Changes

  • specify bee cache directory in windows docker command

Related Issues

Related PRs

ø

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.

  • ...

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Summary by CodeRabbit

  • New Features
    • Added support for the BEE_CACHE_DIRECTORY environment variable in the Docker run command on Windows.

…for windows docker run command and cache to Library directory
Copy link

coderabbitai bot commented Jul 13, 2025

📝 Walkthrough

Walkthrough

A new environment variable, BEE_CACHE_DIRECTORY, is added to the Docker run command for Windows in the getWindowsCommand method. This variable is set to a specific path inside the Docker workspace. No other logic or exported entity signatures are changed.

Changes

File(s) Change Summary
src/model/docker.ts Added BEE_CACHE_DIRECTORY env variable to Windows Docker command.

Poem

A hop, a skip, a Docker tweak,
For Windows bees, a cache to seek.
With paths aligned and envs anew,
The containers hum, their work in view.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e91ca9 and b0da2cf.

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
📒 Files selected for processing (1)
  • src/model/docker.ts (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/model/docker.ts (1)
src/model/input.ts (1)
  • dockerWorkspacePath (240-242)
🔇 Additional comments (1)
src/model/docker.ts (1)

110-110: LGTM! Good addition for Windows incremental build caching.

The new BEE_CACHE_DIRECTORY environment variable correctly specifies the bee cache location for Unity's incremental build system on Windows. The path construction follows the established pattern and Windows conventions, which should help address the difficulty in locating incremental build artifacts mentioned in issue #716.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Cat Gif

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (9e91ca9) to head (b0da2cf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #717    +/-   ##
========================================
  Coverage   37.05%   37.05%            
========================================
  Files          77       77            
  Lines        3163     3163            
  Branches      626      662    +36     
========================================
  Hits         1172     1172            
+ Misses       1991     1843   -148     
- Partials        0      148   +148     
Files with missing lines Coverage Δ
src/model/docker.ts 10.20% <ø> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant