Refactor proxy.shouldTerminate function and move the functionality to Act.Registry
#615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Act.Registry Simplify syntax and avoid unnecessary loops (using maps.Keys) Create RunAll and ShouldTerminate functions in Act.Registry
Overview
Packages and Vulnerabilities (5 package changes and 0 vulnerability changes)
Changes for packages of type
|
| Package | Versionghcr.io/gatewayd-io/gatewayd:f76cd2b |
Versiongatewaydio/gatewayd:latest |
|
|---|---|---|---|
| ➖ | ca-certificates | 20240705-r0 |
|
| ➖ | openssl | 3.3.2-r0 |
|
| ➖ | pax-utils | 1.3.7-r2 |
Changes for packages of type golang (2 changes)
| Package | Versionghcr.io/gatewayd-io/gatewayd:f76cd2b |
Versiongatewaydio/gatewayd:latest |
|
|---|---|---|---|
| ♾️ | github.com/gatewayd-io/gatewayd | (devel) |
0.9.8 |
| ♾️ | stdlib | go1.23.2 |
1.23.1 |
sinadarbouy
approved these changes
Oct 7, 2024
Collaborator
sinadarbouy
left a comment
sinadarbouy
left a comment
There was a problem hiding this comment.
All of the review comments are minor and can be skipped if needed, LGTM
act/registry.go
Outdated
Comment on lines
451
to
452
| _, ok := result[sdkAct.Terminal] | ||
| return ok && cast.ToBool(result[sdkAct.Terminal]) |
Collaborator
There was a problem hiding this comment.
Nit:
Avoids casting if the key doesn’t exist
Improved type safety with the use of ok checks
Suggested change
| _, ok := result[sdkAct.Terminal] | |
| return ok && cast.ToBool(result[sdkAct.Terminal]) | |
| terminalVal, exists := result[sdkAct.Terminal] | |
| if !exists { | |
| r.Logger.Debug().Msg("'__Terminal__' key not found, request will continue.") | |
| return false | |
| } | |
| shouldTerminate, ok := cast.TryBool(terminalVal) | |
| if !ok { | |
| r.Logger.Warn().Msg("'__Terminal__' key exists but cannot be cast to a boolean.") | |
| return false | |
| } | |
| if shouldTerminate { | |
| r.Logger.Info().Msg("Request is marked as terminal. Terminating.") | |
| } | |
| return shouldTerminate |
Member
Author
|
@sinadarbouy Thanks for the review. I addressed the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Related to #397.
Description
This refactoring is the preliminary work to enable processing of notification hooks and in turn let plugins publish actions via notification hooks.
Related PRs
N/A
Development Checklist
make gen-docscommand.Legal Checklist