Skip to content

Conversation

deepeshahlawat
Copy link
Contributor

@deepeshahlawat deepeshahlawat commented Feb 1, 2025

🚀 Pull Request

Description
Changed the color of the register page in dark mode so that the text is visible.


Related Issue
Fix #668


Type of Change
What kind of change does this pull request introduce?

  • 🐛 Bug fix
  • 🚀 New feature
  • 📄 Documentation update
  • 🛠️ Code improvement/refactor
  • 🖼️ UI/UX update
  • Other (please specify)

Screenshots (if applicable)
image


Checklist
Please ensure the following tasks are complete before submitting the pull request:

  • I have tested my changes and ensured they work as expected.
  • I have added any necessary documentation or comments.
  • I have checked the existing issues and pull requests to avoid duplicates.
  • I have starred this repository.
  • I have reviewed my code for best practices and readability.
  • I have included any relevant tests (if applicable).

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for visionary-fenglisu-db1b1d ready!

Name Link
🔨 Latest commit 03fc31c
🔍 Latest deploy log https://app.netlify.com/sites/visionary-fenglisu-db1b1d/deploys/67a62e032affd60008989538
😎 Deploy Preview https://deploy-preview-673--visionary-fenglisu-db1b1d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gauravsingh1281
Copy link
Owner

@iarmaanx review this Pr

@deepeshahlawat
Copy link
Contributor Author

any updates? @gauravsingh1281

@gauravsingh1281 gauravsingh1281 requested review from harmeetsingh11 and removed request for iarmaanx February 6, 2025 18:23
Copy link
Contributor

@harmeetsingh11 harmeetsingh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepeshahlawat the labels and placeholder of the input field are same. Could you please change the placeholders attributes of the input fields to something modern and practical?

@deepeshahlawat
Copy link
Contributor Author

@harmeetsingh11 sir is this fine?

image

@harmeetsingh11 harmeetsingh11 merged commit e807d83 into gauravsingh1281:main Feb 7, 2025
5 checks passed
@harmeetsingh11 harmeetsingh11 added enhancement New feature or request good first issue Good for newcomers level1 labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix colors on Register page to improve Visibility

3 participants