Skip to content

Conversation

@deepeshahlawat
Copy link
Contributor

🚀 Pull Request

Description
Fixed:
The get started button doesn't do anything
The cards on our features are not visible in dark mode
Why choose us section is lacking color diversity to look visually appealing
what are clients says cards are not visible dark.
The page scrolls automatically to the top after releasing the scroll bar.


Related Issue
Closes #669


Type of Change
What kind of change does this pull request introduce?

  • 🐛 Bug fix
  • 🚀 New feature
  • 📄 Documentation update
  • 🛠️ Code improvement/refactor
  • 🖼️ UI/UX update
  • Other (please specify)

Screenshots (if applicable)
https://github.com/user-attachments/assets/a55ceab6-4f93-4860-a31e-7afa596ca00a


Checklist
Please ensure the following tasks are complete before submitting the pull request:

  • I have tested my changes and ensured they work as expected.
  • I have added any necessary documentation or comments.
  • I have checked the existing issues and pull requests to avoid duplicates.
  • I have starred this repository.
  • I have reviewed my code for best practices and readability.
  • I have included any relevant tests (if applicable).

@netlify
Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for visionary-fenglisu-db1b1d ready!

Name Link
🔨 Latest commit 7f70bc1
🔍 Latest deploy log https://app.netlify.com/sites/visionary-fenglisu-db1b1d/deploys/679f1731f106910008ed4c7a
😎 Deploy Preview https://deploy-preview-674--visionary-fenglisu-db1b1d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@harmeetsingh11 harmeetsingh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepeshahlawat Could you please do these changes:
In dark mode, the cards under features and clients section should have dark background with light text and vice-versa in light mode.

@deepeshahlawat
Copy link
Contributor Author

@deepeshahlawat Could you please do these changes: In dark mode, the cards under features and clients section should have dark background with light text and vice-versa in light mode.

@harmeetsingh11 Please check now

@harmeetsingh11
Copy link
Contributor

@deepeshahlawat Could you please do these changes: In dark mode, the cards under features and clients section should have dark background with light text and vice-versa in light mode.

@harmeetsingh11 Please check now

@deepeshahlawat please share the video, I'm unable to see changes in deploy preview.

@deepeshahlawat
Copy link
Contributor Author

demo.1.mp4

@harmeetsingh11 here is the video

@harmeetsingh11 harmeetsingh11 merged commit d5760ec into gauravsingh1281:main Feb 2, 2025
5 checks passed
@deepeshahlawat
Copy link
Contributor Author

@gauravsingh1281 please give me points for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OTHER] Fix and improve total rent collected page

3 participants