Fix [BUG] Navbar menu link not visible #694 #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for visionary-fenglisu-db1b1d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @naitikhoriya1! 🎉 Thank you for submitting your pull request for Rentalog. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.
gauravsingh1281
approved these changes
Apr 6, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a focused pull request template addressing just the navbar menu link visibility issue:
🚀 Pull Request
Description
Fixed the navbar menu link visibility issue by repairing the mobile menu toggle functionality in the Navbar component.
Related Issue
Closes #694 - Navbar menu link not visible
Type of Change
What kind of change does this pull request introduce?
Screenshots after fixed the issue
Checklist
Please ensure the following tasks are complete before submitting the pull request:
Additional Context
This PR addresses the navbar menu link visibility issue by removing a problematic
alertstatement in thetoggleDarkModefunction of Navbar.jsx that was interfering with the menu display. The alert was causing unexpected behavior when toggling dark mode, disrupting the UI flow and hiding menu links.The fix was simple but effective - removing the unnecessary debugging alert that was displaying the
showMenustate value unnecessarily. The navbar menu links now display properly on all screen sizes.