Improvements to Profiler Tutorial #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly create new project directory called profiler_example - Download profiler.cc into directory using wget - Remove unnecessary grep dependency - Clarify the CMakeLists is being created, not modified - Separate the different options for running the profiler visualization into multiple blocks, with the conditions described more clearly - Would like confirmation on what IP address http.server broadcasts to; tutorial says it's the container's IP address, but it always showed up as 0.0.0.0 (localhost) for me in my container Signed-off-by: Harrison Chen <hchen.robotics@gmail.com>
ahcorde
approved these changes
Sep 23, 2025
ahcorde
changed the title
|
I don't have much context for this error - is this something for me to fix on my end? If it's a formatting issue, I had asked in the description about formatting guidelines, if those are available somewhere. I wasn't able to find them. |
|
@chen-harrison I'm not sure what the windows failure is, but this is just a documentation update, so it shouldn't cause any test failures. It might be related to gazebo-tooling/release-tools#1405 cc @j-rivero I'll go ahead and merge this. |
|
@Mergifyio backport gz-common6 gz-common5 ign-common4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
- Explicitly create new project directory called profiler_example - Download profiler.cc into directory using wget - Remove unnecessary grep dependency - Clarify the CMakeLists is being created, not modified - Separate the different options for running the profiler visualization into multiple blocks, with the conditions described more clearly - Would like confirmation on what IP address http.server broadcasts to; tutorial says it's the container's IP address, but it always showed up as 0.0.0.0 (localhost) for me in my container Signed-off-by: Harrison Chen <hchen.robotics@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 2b33445) # Conflicts: # tutorials/profiler.md
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
- Explicitly create new project directory called profiler_example - Download profiler.cc into directory using wget - Remove unnecessary grep dependency - Clarify the CMakeLists is being created, not modified - Separate the different options for running the profiler visualization into multiple blocks, with the conditions described more clearly - Would like confirmation on what IP address http.server broadcasts to; tutorial says it's the container's IP address, but it always showed up as 0.0.0.0 (localhost) for me in my container Signed-off-by: Harrison Chen <hchen.robotics@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 2b33445) # Conflicts: # tutorials/profiler.md
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
- Explicitly create new project directory called profiler_example - Download profiler.cc into directory using wget - Remove unnecessary grep dependency - Clarify the CMakeLists is being created, not modified - Separate the different options for running the profiler visualization into multiple blocks, with the conditions described more clearly - Would like confirmation on what IP address http.server broadcasts to; tutorial says it's the container's IP address, but it always showed up as 0.0.0.0 (localhost) for me in my container Signed-off-by: Harrison Chen <hchen.robotics@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 2b33445) # Conflicts: # tutorials/profiler.md
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.