-
Notifications
You must be signed in to change notification settings - Fork 50
Kinematic Tag for Dartsim (Harmonic) #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kinematic Tag for Dartsim (Harmonic) #756
Conversation
This depends on this MR https://github.com/dartsim/dart/pull/1953/commits |
kinematic-tag-demo-2025-07-09_19.08.49.mp4A comparison between kinematic and non-kinematic collision with static box |
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
61bf81c
to
14c283d
Compare
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
777cdcc
to
72e1caf
Compare
Signed-off-by: Jose Mayoral <jocamaba1989@gmail.com>
@jcmayoral Thanks for the contribution!! This is a greatly needed feature. However, I suggest targeting the PR to Could you also please fill out the description following the template provided? That will help provide context for the PR. Finally, since this depends on an upstream change that's not merged yet, I'll remove it from the Jetty milestone. But please don't let this stop you from pushing on this PR. Once the Jetty is released, we'll be able to merge this. |
Hi @azeey. I will update this to point to main. But I have removed the dependency on the external MR. Now this one is the one needed. I removed the other MR because of two main reasons:
Please, reconsider to integrate this feature for jetty release. |
Oh interesting. I didn't realize the upstream change wasn't needed. In that case, I'll close this PR and we'll review #758 toward getting it into Jetty. We can backport to Ionic/Harmonic once that lands. |
🦟 Bug fix
Fixes #
Summary
Checklist
codecheck
passed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Closes #
Summary
Test it
Checklist
codecheck
passed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
➡️ Forward port
Port <FROM_BRANCH> to <TO_BRANCH>
Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎈 Release
Preparation for <X.Y.Z> release.
Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>
Needed by <PR(s)>
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.