Skip to content

Testing CI for #753 #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Testing CI for #753 #760

wants to merge 13 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 17, 2025 •
edited
Loading

🎉 New feature

Summary

see #753

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

srmainwaring and others added 12 commits June 29, 2025 13:09
@srmainwaring
BallJoint: apply axis properties to ball joints
b8045bb 
- Allow dynamics properties to be applied to ball joints in dart sim.

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@srmainwaring
BallJoint: include <cstddef>
0e8c870 
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@srmainwaring
BallJoint: comment unused function arguments
fa15dff 
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@iche033 @srmainwaring
BallJoint: add test
b6beef1 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
test commenting axis out
8f97d8e 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
test ci
763e282 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
debugging
3e92684 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
testing
7a78c19 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
remove debug print
c1e5e03 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
revert
ba00fdd 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
revert one change
eb65899 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
revert github ci
eb8df7d 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested review from azeey and scpeters as code owners July 17, 2025 23:32
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 17, 2025
@iche033 iche033 changed the title Iche033/pr ball joint properties Testing CI for #3727 Jul 17, 2025
@iche033 iche033 changed the title Testing CI for #3727 Testing CI for #753 Jul 17, 2025
@iche033 iche033 closed this Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @srmainwaring