-
Notifications
You must be signed in to change notification settings - Fork 50
Enable/disable: gravity and static #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gz-physics7
Are you sure you want to change the base?
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
// Verify that the model qualifies as a FreeGroup | ||
dart::dynamics::SkeletonPtr &skeleton = modelInfo->model; | ||
|
||
std::cout << "SetFreeGroupStaticState " << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
|
||
std::cout << "SetFreeGroupStaticState " << std::endl; | ||
|
||
if (skeleton) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Move the {
to the next line. Also, remove the else
branch?
auto *bn = info.model->getRootBodyNode(i); | ||
bn->setGravityMode(_enabled); | ||
} | ||
// const auto modelInfo = this->models.at(_groupID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this block?
public: template <typename PolicyT, typename FeaturesT> | ||
class FreeGroup : public virtual Entity<PolicyT, FeaturesT> | ||
{ | ||
/// \brief Set this FreeGroup pose in world frame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comment?
public: template <typename PolicyT, typename FeaturesT> | ||
class FreeGroup : public virtual Entity<PolicyT, FeaturesT> | ||
{ | ||
/// \brief Set this FreeGroup pose in world frame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comment?
🎉 New feature
Summary
Allow to enable/disable gravity and static state
Test it
Checklist
codecheck
passed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.