Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 24, 2024

🦟 Bug fix

Fixes #2531

Summary

See #2531 for instructions on reproducing the crash.

Added a check for non-empty laser scan ranges before accessing the elements.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from mjcarroll as a code owner August 24, 2024 00:58
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 24, 2024
@iche033 iche033 merged commit a33e246 into gz-sim8 Aug 26, 2024
@iche033 iche033 deleted the elevator_fix branch August 26, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Crash after calling /model/elevator/door_0/lidar topic with empty gz.msgs.LaserScan message

3 participants