Skip to content

Conversation

alesof
Copy link
Contributor

@alesof alesof commented Aug 30, 2024

🦟 Bug fix

Related to #1646

Summary

To reproduce the error run the simulation in gazebo ionic.
Output:

[error] The use of added mass through this plugin is deprecated and willbe removed in Gazebo J* as this formulation has instabilities. We recommend using the SDF `<fluid_added_mass>` tag based method[http://sdformat.org/spec?ver=1.11&elem=link#inertial_fluid_added_mass]To get rid of this warning we recommend setting`<disable_added_mass> to true.

By adding the suggested tag the warning is removed.

Removes warning of deprecated setting.

Signed-off-by: Alessandro Sofia <al.sofia@studenti.unina.it>
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just disabling added mass is not sufficient. We need to add it to the links in the model themselves (See #2575). If you'd like to you can download the model from fuel and update it. Also I think we should change the typos in the error message in hydrodynamics and make it explicit that you should set the added mass parameters on the links themselves.

http://sdformat.org/spec?ver=1.11&elem=link#inertial_fluid_added_mass

@arjo129 arjo129 self-assigned this Sep 2, 2024
@arjo129
Copy link
Contributor

arjo129 commented Sep 2, 2024

I've opened #2579 as an alternative to this PR. Thanks @alesof for bringing this to my notice!

@arjo129 arjo129 closed this Sep 2, 2024
@alesof alesof deleted the patch-1 branch September 2, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants