Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 31, 2024

🦟 Bug fix

Summary

Fix crash that happens when the optical tactile plugin loads SDF Element parameters.

Updated to read parameters differently:

  • The sensor's update rate field should be available so skipped the check
  • The sensor topic can be can be found in the SensorTopic component. If for some reason it's empty, get it from the Sensor DOM object.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit 4597293 into gz-sim9 Sep 3, 2024
10 checks passed
@iche033 iche033 deleted the optical_tactile_plugin_crash branch September 3, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants