Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 4, 2024

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1593

Breadcrumbs are made static some time after being deployed. This is done by attaching a fixed joint between its canonical link and a dummy static model. However, the logic for finding the canonical link did not work if the breadcrumb is a nested model. This PR fixes finding the canonical link in a nested breadcrumb model so that it can be made static.

To test

launch breadcrumbs.sdf world

gz sim -v 4 -r breadcrumbs.sdf

Deploy B2

gz topic -t "/B2/deploy" -m gz.msgs.Empty -p "unused: true"

Wait a few seconds and make sure no error msgs such as [error] Failed to make breadcrumb 'B2_0' static. is printed.

The deployed breadcrumb model should be static.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Sep 10, 2024

The UNIT_Server_TEST failed on gz_sim-ci-pr_any-noble-amd64. Looks like it's flaky, I see it failing on gz-sim9 branch and other PRs. Ticketed #2609

@iche033 iche033 merged commit 9b161db into gz-sim9 Sep 10, 2024
9 of 10 checks passed
@iche033 iche033 deleted the breadcrumb_nested_canonical branch September 10, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

gz-sim: breadcrumbs.sdf

2 participants