-
Notifications
You must be signed in to change notification settings - Fork 339
Add LookupWheelSlip system #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4fe861
to
fb47e4d
Compare
ahcorde
requested changes
Jul 28, 2025
9 tasks
Signed-off-by: Ian Chen <ichen@openrobotics.org>
59551c0
to
435cc35
Compare
* Add test world for lookup wheel slip system Signed-off-by: Jenn Nguyen <8602001+jennuine@users.noreply.github.com> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
…l_slip_system' into iche033/lookup_wheel_slip_system
Signed-off-by: Ian Chen <ichen@openrobotics.org>
The homebrew build failure should be fixed by #3032 |
jennuine
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor nits on docs. Thanks Ian!
Signed-off-by: Ian Chen <ichen@openrobotics.org>
10 tasks
I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Adds a new LookupWheelSlip system that uses an 8 bit RGB lookup map for dynamically adjusting the wheel slip / friction params based on the position of the wheel links on the target region.
This system needs to be used together with the WheelSlip system. The systems work together as follows:
Test it
Run the example
lookup_wheel_slip.sdf
world. This world has small -x gravity to simulate vehicle climbing up a hill so we can see the effect of wheelslip.Publish commands to move the two vehicles forward
The blue vehicle has the
LookupWheelSlip
plugin attached so when it traverses over the slip regions (green), the wheels' longitudinal slip compliance values get dynamically adjusted (increased), i.e vehicle right wheel slips it comes into contact with the slip region causing it to turn to the right. Similar behavior when the left wheel enters the slip region.The green vehicle has fixed slip compliance parameters and so the behavior remains consistent, i.e. drives in a straight line
Checklist
codecheck
passed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.