Skip to content

Conversation

@Zyrin
Copy link
Contributor

@Zyrin Zyrin commented Aug 12, 2025

🦟 Bug fix

Fixes #2829

Summary

Add missing virtual destructors so that "-Wnon-virtual-dtor" in combination with "-Werror" does not cause any issues.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com>
@Zyrin Zyrin requested a review from arjo129 as a code owner August 12, 2025 07:32
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Aug 12, 2025
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be in favour of this, however it is important to acknowledge that this potentially breaks ABI and should not be backported.

Gazebo is currently in a "feature freeze" till its next release, so we will not be able to merge these changes till after the jetty release as we will be holding main frozen for about 1.5 months.

@Zyrin
Copy link
Contributor Author

Zyrin commented Aug 12, 2025

Do you have any idea why the UtilTest.ResolveSdfWorldFile test fails on gz_sim-ci-pr_any-homebrew-amd64, but passes on gz_sim-ci-pr_any-noble-amd64?

@arjo129
Copy link
Contributor

arjo129 commented Aug 12, 2025

I don't think the test failures there are related to your change.

@azeey
Copy link
Contributor

azeey commented Aug 12, 2025

Gazebo is currently in a "feature freeze" till its next release, so we will not be able to merge these changes till after the jetty release as we will be holding main frozen for about 1.5 months.

I'd consider this a bug fix so it's okay to merge while we are in feature freeze.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 18, 2025
@arjo129 arjo129 enabled auto-merge (squash) August 18, 2025 11:47
@azeey azeey added this to the Jetty Release milestone Aug 19, 2025
@azeey azeey disabled auto-merge August 19, 2025 01:14
@azeey
Copy link
Contributor

azeey commented Aug 19, 2025

Failing test is not related to this PR (see #3031)

@azeey azeey merged commit c5933fa into gazebosim:main Aug 19, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants