Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 15, 2025

🦟 Bug fix

Summary

Ports the fix from gazebosim/gz-launch#295

This should fix the recent homebrew build failures:

/Users/jenkins/jenkins-agent/workspace/gz_sim-ci-pr_any-homebrew-amd64/gz-sim/src/systems/websocket_server/WebsocketServer.cc:1053:24: error: invalid operands to binary expression ('basic_string<char, char_traits<char>, allocator<char>>' and 'absl::string_view' (aka 'basic_string_view<char>'))

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from arjo129 as a code owner August 15, 2025 19:04
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Aug 15, 2025
@iche033 iche033 mentioned this pull request Aug 15, 2025
10 tasks
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 18, 2025
@scpeters scpeters merged commit e3f2d88 into main Aug 18, 2025
14 checks passed
@scpeters scpeters deleted the iche033/proto_compat branch August 18, 2025 18:34
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants