Fix comment for logical camera topic #3043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that the updated topic name is correct. Thanks for the fix! |
iche033
approved these changes
Aug 28, 2025
arjo129
approved these changes
Aug 28, 2025
|
@akky20 Can you follow the instructions here: https://github.com/gazebosim/gz-sim/pull/3043/checks?check_run_id=49137846790 This will make DCO pass. |
ahcorde
approved these changes
Aug 29, 2025
|
Hi @akky20, I think this is only waiting for DCO to pass. Can you take a quick look? |
akky20
force-pushed
the
akky20-edited-typoerror-visualize_frustum
branch
2 times, most recently
from
6851f1d to
bcdd861
Compare
Updated topic name in comments for logical camera sensor. issue from gazebosim#2252 Signed-off-by: Abhiroop <126786356+akky20@users.noreply.github.com> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
…3041) Signed-off-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
Signed-off-by: Nikodem Janik <nikodemj@gmail.com> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
…3042) Signed-off-by: jmackay2 <1.732mackay@gmail.com> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
Similar to the changes in gazebosim/gz-gui#711. This was missed during the Qt5 -> Qt6 migration. The fileUrl var has changed to selectedFile Signed-off-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
…Prevent Crash (gazebosim#3051) if scene is not initialized correctly, we should add a check and return directly. --------- Signed-off-by: momo <2438833481@qq.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
akky20
force-pushed
the
akky20-edited-typoerror-visualize_frustum
branch
from
9c04b07 to
fd63532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for Issue
Summary
Updated topic name in comments for logical camera sensor.
Checklist