generated from gccloudone/oss-templates
-
Notifications
You must be signed in to change notification settings - Fork 2
chore: configuring Jfrog OIDC #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sylus
wants to merge
40
commits into
main
Choose a base branch
from
feat/jfrog-oidc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoteFrogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
So this is supposed to work now with 2.78.3 and I think @KingBain got it to work, so I'm very confused lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to OIDC Authentication for Enhanced Security
There are still some upstream bugs that need to be merged:
Summary
This pull request migrates all GitHub Actions workflows from secret-based authentication to OpenID Connect (OIDC) for secure, credential-less access to JFrog Artifactory.
What Changed
Security Improvements
JFROG_USERNAME
andJFROG_JWT_TOKEN
from repository secretsid-token: write
to all jobs requiring JFrog accessFiles Modified
.github/workflows/java-app.yml
- Updated Java workflow with OIDC.github/workflows/python-app.yml
- Updated Python workflow with OIDC.github/workflows/node-app.yml
- Updated Node.js workflow with OIDC.github/workflows/update-chainguard-digests.yml
- Updated digest update workflow with OIDCdocs/quickstart.md
- Added OIDC configuration documentationTechnical Changes
jf docker-login
commandid-token: write
to all relevant workflow jobsThanks to @KingBain for Jfrog OIDC