Skip to content

Conversation

sylus
Copy link
Contributor

@sylus sylus commented Jun 3, 2025

Migrate to OIDC Authentication for Enhanced Security

There are still some upstream bugs that need to be merged:

Summary

This pull request migrates all GitHub Actions workflows from secret-based authentication to OpenID Connect (OIDC) for secure, credential-less access to JFrog Artifactory.

What Changed

Security Improvements

  • Removed stored secrets: Eliminated JFROG_USERNAME and JFROG_JWT_TOKEN from repository secrets
  • Added OIDC authentication: Implemented workflow-specific identity mappings
  • Enhanced permissions: Added id-token: write to all jobs requiring JFrog access
  • Token expiration: Limited authentication tokens to 10 minutes maximum

Files Modified

  • .github/workflows/java-app.yml - Updated Java workflow with OIDC
  • .github/workflows/python-app.yml - Updated Python workflow with OIDC
  • .github/workflows/node-app.yml - Updated Node.js workflow with OIDC
  • .github/workflows/update-chainguard-digests.yml - Updated digest update workflow with OIDC
  • docs/quickstart.md - Added OIDC configuration documentation

Technical Changes

  • JFrog CLI Setup: Replaced secret-based auth with OIDC provider configuration
  • Docker Login: Changed from credential-based to jf docker-login command
  • Frogbot Configuration: Updated to use OIDC environment variables
  • Permissions: Added id-token: write to all relevant workflow jobs

Thanks to @KingBain for Jfrog OIDC

@simardeep1792 simardeep1792 self-requested a review June 3, 2025 14:36
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

Note

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.



@sylus
Copy link
Contributor Author

sylus commented Aug 13, 2025

So this is supposed to work now with 2.78.3 and I think @KingBain got it to work, so I'm very confused lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants