Fixed Percent delimiter for hex encoding#2137
Merged
C85297 merged 3 commits intogchq:masterfrom Feb 11, 2026
Merged
Conversation
Member
|
Issue replicated: https://gchq.github.io/CyberChef/#recipe=To_Hex('Percent',0)&input=YWJjZGVmZw |
C85297
requested changes
Feb 10, 2026
Member
C85297
left a comment
There was a problem hiding this comment.
This looks good to me @beneri , however it would benefit from some tests. Would you be able to create a test file tests/operations/tests/ToHex.mjs (you can use any of the other files in that directory as a template) to check that ToHex correctly performs the new behaviour as expected?
Contributor
Author
|
Good point about tests! I've added a new test for the percent delimiter. |
C85297
approved these changes
Feb 11, 2026
Member
|
Thank you for your contribution @beneri ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #464
Percent (%) should be prepended, similar to "\x" and "0x".