feat(selectivity): add ability to save selectivity report#1221
feat(selectivity): add ability to save selectivity report#1221KuznetsovRoman merged 1 commit intomasterfrom
Conversation
| const reportPath = | ||
| process.env.TESTPLANE_SELECTIVITY_REPORT_PATH || | ||
| this._config.forBrowser(browserId).selectivity.reportPath; |
There was a problem hiding this comment.
Saving report is optional and turned off by default
To enable saving this report, user should set "reportPath" in config if he needs this report
On tasklet side, we can conveniently override it with "TESTPLANE_SELECTIVITY_REPORT_PATH" env variable
KuznetsovRoman
force-pushed
the
TESTPLANE-938.selectivity_report
branch
from
437651e to
10c7d8e
Compare
commit: |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10c7d8e058
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
KuznetsovRoman
force-pushed
the
TESTPLANE-938.selectivity_report
branch
from
10c7d8e to
7fe48ae
Compare
| const promises = await Promise.allSettled( | ||
| Object.keys(browserReportPaths).map(async reportPath => { | ||
| const report: SelectivityReport = { | ||
| totalProcessedCount: 0, |
There was a problem hiding this comment.
maybe totalCount and skipperCount? Processed is to long, imho
There was a problem hiding this comment.
totalCount is missleading.
If test was disabled at the start, it was not inspected "should it be run or not"
The same with browsers, which has disabled selectivity: its not counted.
So "processed" its "testplane selectivity inspected, whether this test should be executed or not"
2 participants
No description provided.