fix: make BrowserConfig typing deterministic#1234
Open
ekazakov14 wants to merge 1 commit intogemini-testing:masterfrom
Open
fix: make BrowserConfig typing deterministic#1234ekazakov14 wants to merge 1 commit intogemini-testing:masterfrom
ekazakov14 wants to merge 1 commit intogemini-testing:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BrowserConfig receives ~40 properties dynamically via
_.extend(this, browserOptions)in the constructor. Since TypeScript cannot infer dynamically assigned properties, the type information was added through adeclare module "./browser-config"augmentation at the bottom of types.ts.This pattern is order-dependent: the augmentation is only applied if types.ts is loaded before browser-config.d.ts is used. TypeScript's language server and newer type checkers like tsgo (TypeScript 7) do not guarantee file loading order, which causes intermittent errors:
Property 'id' does not exist on type 'BrowserConfig'Property 'urlHttpTimeout' does not exist on type 'BrowserConfig'These errors appear non-deterministically — present in one run, gone in the next.