feat(selectivity): add ability to save incomplete dumps#1247
Merged
KuznetsovRoman merged 1 commit intomasterfrom Apr 28, 2026
Merged
feat(selectivity): add ability to save incomplete dumps#1247KuznetsovRoman merged 1 commit intomasterfrom
KuznetsovRoman merged 1 commit intomasterfrom
Conversation
commit: |
KuznetsovRoman
commented
Apr 23, 2026
| dependencies.modules.forEach(dependency => this._addModuleDependency(dependency)); | ||
| } | ||
|
|
||
| async save(readExisting?: boolean): Promise<void> { |
Member
Author
There was a problem hiding this comment.
"readExisting = false" had no use case here, and nobody was relying on it here.
Removing it leds to better UX
Comment on lines
+37
to
+39
| if ((isRunFailed || browserConfig.lastFailed.only) && !saveIncompleteDumpOnFail) { | ||
| continue; | ||
| } |
Member
Author
There was a problem hiding this comment.
So, with "saveIncompleteDumpOnFail" we can save data even if test run is failed or "lastFailed" filter was used
| const { enabled, testDependenciesPath, saveIncompleteDumpOnFail } = browserConfig.selectivity; | ||
|
|
||
| if (selectivityShouldWrite(enabled) && !selectivityRoots.includes(testDependenciesPath)) { | ||
| if ((isRunFailed && !saveIncompleteDumpOnFail) || browserConfig.lastFailed.only) { |
Member
Author
There was a problem hiding this comment.
dump cleanup is different: if "browserConfig.lastFailed.only" is enabled, clear should not be performed, because it would remove dependencies for fresh tests, that were just skipped with "lastFailedOnly"
| if (!config.selectivity.saveIncompleteDumpOnFail) { | ||
| logger.warn(`Disabling selectivity for ${browserId}: lastFailedOnly mode is enabled`); | ||
| } else { | ||
| debugSelectivity(`Not skipping tests for ${browserId}: lastFailedOnly mode controls it`); |
Member
Author
There was a problem hiding this comment.
Intended behavior, dont need to warn anything
|
|
||
| if (config.lastFailed.only) { | ||
| if (!config.selectivity.saveIncompleteDumpOnFail) { | ||
| logger.warn(`Disabling selectivity for ${browserId}: lastFailedOnly mode is enabled`); |
Member
Author
There was a problem hiding this comment.
Not intended, writing warning
sonic16x
approved these changes
Apr 24, 2026
KuznetsovRoman
force-pushed
the
TESTPLANE-970.save_incomplete_dump
branch
2 times, most recently
from
31966b4 to
d2bd34e
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-970.save_incomplete_dump
branch
from
d2bd34e to
3381a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
If test run is failed, all dumps are lost, and we have to rerun all tests.
Solution
We can save incomplete data (in cooperation with lastFailedOnly mode) in order to rerun only failed tests, which is much faster