Skip to content

Commit c423d39

Browse files
authored
Merge pull request #593 from Rdataflow/fix--cors-allow-headers
fix: update Access-Control-Allow-Headers for edge using `Accept-Language` header longer 128
2 parents 8024443 + fc672bf commit c423d39

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

app/middleware/cors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ def __call__(self, request):
3333
if request.path in (f'/{STAC_BASE}/v0.9/search', f'/{STAC_BASE}/v1/search'):
3434
allow_methods.append('POST')
3535
response['Access-Control-Allow-Methods'] = ','.join(allow_methods)
36-
response['Access-Control-Allow-Headers'] = 'Content-Type,Accept'
36+
response['Access-Control-Allow-Headers'] = 'Content-Type,Accept,Accept-Language'
3737

3838
return response

app/tests/tests_09/base_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def assertLocationHeader(self, expected_path, response): # pylint: disable=inva
129129

130130
def assertCors(self, response): # pylint: disable=invalid-name
131131
for header, value in {
132-
'Access-Control-Allow-Headers': 'Content-Type,Accept',
132+
'Access-Control-Allow-Headers': 'Content-Type,Accept,Accept-Language',
133133
'Access-Control-Allow-Methods': 'GET,HEAD',
134134
'Access-Control-Allow-Origin': '*'
135135
}.items():

app/tests/tests_09/test_generic_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,7 @@ def test_get_cors_header(self):
684684

685685
self.assertEqual(
686686
response['Access-Control-Allow-Headers'],
687-
'Content-Type,Accept',
687+
'Content-Type,Accept,Accept-Language',
688688
msg='Wrong CORS allow-Headers value'
689689
)
690690

@@ -719,6 +719,6 @@ def test_get_cors_header_search(self):
719719

720720
self.assertEqual(
721721
response['Access-Control-Allow-Headers'],
722-
'Content-Type,Accept',
722+
'Content-Type,Accept,Accept-Language',
723723
msg='Wrong CORS allow-Headers value'
724724
)

app/tests/tests_10/base_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def assertLocationHeader(self, expected_path, response): # pylint: disable=inva
130130

131131
def assertCors(self, response): # pylint: disable=invalid-name
132132
for header, value in {
133-
'Access-Control-Allow-Headers': 'Content-Type,Accept',
133+
'Access-Control-Allow-Headers': 'Content-Type,Accept,Accept-Language',
134134
'Access-Control-Allow-Methods': 'GET,HEAD',
135135
'Access-Control-Allow-Origin': '*'
136136
}.items():

app/tests/tests_10/test_generic_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,7 @@ def test_get_cors_header(self):
677677

678678
self.assertEqual(
679679
response['Access-Control-Allow-Headers'],
680-
'Content-Type,Accept',
680+
'Content-Type,Accept,Accept-Language',
681681
msg='Wrong CORS allow-Headers value'
682682
)
683683

@@ -712,6 +712,6 @@ def test_get_cors_header_search(self):
712712

713713
self.assertEqual(
714714
response['Access-Control-Allow-Headers'],
715-
'Content-Type,Accept',
715+
'Content-Type,Accept,Accept-Language',
716716
msg='Wrong CORS allow-Headers value'
717717
)

0 commit comments

Comments
 (0)