PB-1764: Allow to create coverage reports #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
approved these changes
Jun 12, 2025
Comment on lines
+226
to
+230
| .PHONY: test-ci | ||
| test-ci: | ||
| # Collect static first to avoid warning in the test | ||
| $(PYTHON) $(DJANGO_MANAGER) collectstatic --noinput | ||
| $(PYTEST) -n 20 --cov --cov-report=xml |
There was a problem hiding this comment.
Do you also intend to update the CI ?
There was a problem hiding this comment.
Yes, as soon as this is merged I'll create a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
test-coverage(for local usage) andtest-ci(for pipeline) which run the test and create coverage reports.There was no way to get consistent reports with
coverageand django's test runner (it seems like somehow the duplicate 09/10 tests are getting mixed up). Using the already installedpyteston the other hand works like a charm.Next step would be to change the builder pipeline similar to service-control (this commit). This will show the coverage in the CodeBuild Report (example).