PB-1785: upgrade to psycopg 3. #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we were using psycopg 2.9.10. This does not seem to be designed to [work correctly with gevent](https://www.psycopg.org/docs/advanced.html#support-for-coroutine-libraries) "out of the box". The [psycogreen](https://github.com/psycopg/psycogreen/) library was written to resolve that problem but we don't seem to be using it at all. Upgrading to [psycopg 3 allows proper integration with gevent](https://www.psycopg.org/psycopg3/docs/advanced/async.html#gevent-support) without psycogreen or other workaround. This change upgrades service-stac from psycopg 2.9.10 to 3.2.9. This was done by updating the Pipfile then running `pipenv install`. This also updated other dependencies. In local tests, I verified the `/checker` endpoint remains much more responsive with this change when end-to-end tests are being run. Maximum measured latency dropped from ~15 seconds to ~3 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we were using psycopg 2.9.10. This does not seem to be designed to work correctly with gevent "out of the box". The psycogreen library was written to resolve that problem but we don't seem to be using it at all.
Upgrading to psycopg 3 allows proper integration with gevent without psycogreen or other workaround.
This change upgrades service-stac from psycopg 2.9.10 to 3.2.9. This was done by updating the Pipfile then running
pipenv install. This also updated other dependencies.In local tests, I verified the
/checkerendpoint remains much more responsive with this change when end-to-end tests are being run. Maximum measured latency dropped from ~15 seconds to ~3 seconds.