Suggestions for version 0.1

[falkamelung]

1. There are python options to always overwrite existing files. We also could have a run_or_skip as in MintPy that checks for existing files before running something, but I don’t think it is worth it. Anyway, something to keep in mind so that we can add in the case we add processing.

2. Please make sure the metavar is correct. It is unclear what seismicity=3 means. And what is --seismicity [SEISMICITY] ?

3. --template default is also weired. The default should be the choice if no option is given

4. —colorbar is not used properly. We may want an option —nocolorbar to switch it off . Use —colormap to select COLORMAP. See from MintPy:

view.py --help | grep color
[--base-color NUM] [--blend-mode STR] [--fontsize FONT_SIZE]
[--fontcolor FONT_COLOR] [--nowhitespace] [--noaxis] [--notick]
--base-color NUM [Blend] Topograhpy basemap greyish color ranges in [0,1] (default: 0.7).
--blend-mode STR [Blend] Type of blending used to combine the colormapped data with illumated topography.
-c COLORMAP, --colormap COLORMAP
colormap used for display, i.e. jet, cmy, RdBu, hsv, jet_r, viridis, etc.
More at https://mintpy.readthedocs.io/en/latest/api/colormaps/
number of increment of colormap lookup table (default: 256).
list of 3 float numbers, for truncated colormap only (default: [0.0, 0.7, 1.0]).
--nocbar, --nocolorbar
do not display colorbar

5. Just to clarify. I see --dem DEM_FILE external DEM file (Default: geo/geo_geometryRadar.h5). Is there still an option to use a downloaded DEM? (May not be needed).
   Once these are fixed I will try again.

6. Instead of —show I may suggest to use —display for consistency with MintPy. It has display_flag=True as default and the —no display option. I like display=False as default and —display to switch display on (as you have). But I am not sure. I know that show is used in matplotlib. There may be some reasons that Yunjun chose —display. Let me know what you decide and what are the reasons. From MintPy:

view.py --help | grep display
[-o [OUTFILE ...]] [--save] [--nodisplay] [--update]
display kept interferograms only, without dropped interferograms

--nodisplay save and do not display the figure

view.py velocity.h5 —nodisplay

7. To avoid errors lets add a .circleci as I did for minsar (and Yunjun has for MintPy). It is very easy. We put the Chiles and Hawaii data on xenodo.org, For every git push they are downloaded on the circleci instance and the examples are run. We need some logic to get the examples from the code. I have seen somewhere something like from cli.plot_data import EXAMPLE, i.e. define them as a function and skip over lines that don’t start with plot_data.py there may be better ways. My PlotData had a notebook to always run the examples, but circleci is much better.

For the submission of the Chiles paper we need data on xenodo.org anyway. Let’s start this now and update the data when the paper is done.

8. Real programmers think always about writing tests.

9. We now need to think of a logic on how to specify options in a *template file and overwrite them by command line options.

[disilvestro]

Hey @falkamelung

• 1 - Noted
• 2 - Fixed, now the metavar says: MAGNITUDE
• 3 - It is already like this.
• 4 - I don't get it, you want me to add all those options?
• 5 - I left it there from your code to remind me to add it later. I don't really know what was the main scope and i was planning on asking you once i started working on it
• 6 - I don't think having a no-show as a default for a script like plot_data, whose purpose is to show plot, is a good idea. Also sometimes display may be misunderstood with displaying options and not simply 'show' (i am not sure if i said it right). Plot data has no-show=False as default.
• 7 - I'll try to work on that
• 8 - I am not a real programmer and I'll never be, but i agree, tests are important
• 9 - I had an idea but we have to discuss it personally to better understand what we want