bbox-crs parameter mishandled in OAMaps

[webb-ben]

Description
The bbox-crs parameter is improperly conflates crs and bbox-crs

pygeoapi/pygeoapi/api/maps.py

Line 105 in 9a71a01

query_args['crs'] = request.params.get('bbox-crs', 4326)

resulting in errors during CRS conversion. This is different than the behavior when compared to OAFeat/OARec

pygeoapi/pygeoapi/api/itemtypes.py

Lines 402 to 412 in a90f545

	if len(bbox) > 0:
	try:
	# Get a pyproj CRS instance for the Collection's Storage CRS
	storage_crs = provider_def.get('storage_crs', DEFAULT_STORAGE_CRS) # noqa
	# Do the (optional) Transform to the Storage CRS
	bbox = transform_bbox(bbox, bbox_crs, storage_crs)
	except CRSError as e:
	return api.get_exception(
	HTTPStatus.BAD_REQUEST, headers, request.format,
	'NoApplicableCode', str(e))

Steps to Reproduce

• Query with bbox ESPG4269
  https://demo.pygeoapi.io/master/collections/mapserver_world_map/map?f=png&bbox=-88.374023,24.826625,-78.112793,31.015279
  
  The underlying query to WMS has query arguments: bbox=-130.516667,24.1,-62.25273100000001,58.240301 and srs=EPSG:4326

• Query with bbox ESPG4269 and bbox-crs EPSG3857
  https://demo.pygeoapi.io/master/collections/mapserver_world_map/map?f=png&bbox=-88.374023,24.826625,-78.112793,31.015279&bbox-crs=http://www.opengis.net/def/crs/EPSG/0/3857
  
  The underlying query to WMS has query arguments: bbox=-9837751.239713045,2854464.3896094887,-8695476.341200383,3634733.5713922237 and srs=EPSG:3857

• Query with bbox ESPG3857 and bbox-crs EPSG3857
  https://demo.pygeoapi.io/master/collections/mapserver_world_map/map?f=png&bbox=-9837751.2884,2854464.3843,-8695476.3377,3634733.5690&bbox-crs=http://www.opengis.net/def/crs/EPSG/0/3857
  errors.
  The underlying query to WMS has query arguments: bbox=inf,inf,inf,inf and srs=EPSG:3857

Expected behavior
pygeoapi is able to appropriately convert bbox CRS without while fulfilling the requirements of https://docs.ogc.org/is/20-058/20-058.html#req_spatial-subsetting_bbox-crs

Screenshots/Tracebacks
The error happens because bbox-crs controls the CRS used for the subquery, not the CRS of the bbox provided in the request. This can be seen in the request made to the WMS

lib/python3.12/site-packages/urllib3/connectionpool.py:475} DEBUG - https://mapservices.weather.noaa.gov:443 "GET /raster/services/snow/NOHRSC_Snow_Analysis/MapServer/WMSServer?version=1.1.0&service=WMS&request=GetMap&bbox=inf%2Cinf%2Cinf%2Cinf&srs=EPSG%3A3857&layers=1&styles=default&width=500&height=300&format=image%2Fpng&transparent=TRUE HTTP/1.1" 200 159
INFO:     127.0.0.1:56373 - "GET /collections/nohrsc-swe/map?bbox=-15328796.3079,2554678.3593,-5828590.9363,8415258.1920&bbox-crs=http://www.opengis.net/def/crs/EPSG/0/3857 HTTP/1.1" 200 OK

The WMSFacade provider always converts the input bbox CRS from 4269 to whatever bbox-crs is:

pygeoapi/pygeoapi/provider/wms_facade.py

Lines 97 to 101 in 9a71a01

	src_crs = pyproj.CRS.from_string('epsg:4326')
	dest_crs = pyproj.CRS.from_string(CRS_CODES[crs])
	transformer = pyproj.Transformer.from_crs(src_crs, dest_crs,
	always_xy=True)

Environment

• OS: All
• Python version: 0.21.dev0
• pygeoapi version: 3.10+

Additional context
Add any other context about the problem here.