Conversation
|
@tdipisa Hi Tobia |
|
@tha-nordiq I'm sorry for the late answer. Can you please update your PR to the latest master and resolve conflicts please? |
0218238 to
87f2102
Compare
|
In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code |
There was a problem hiding this comment.
@tha-nordiq
Kindly align your branch with latest master and resolve conflicts and please grant me write access to your branch nordiq-group:danish_i18n. I would like to push some updates as part of the review. Since the changes are extensive (missing translation keys), it would be difficult to include them directly in the comments, so I plan to add them as a separate commit instead. Once updated, you could review them, and we can proceed further.
Additionally, you will need to sign the CLA in order to contribute.
|
Sorry but recent changes due to CLA and github action checks invalidated your PR 2 times before we had time to merge. |
|
@offtherailz thank you. The CLA is signed @tha-nordiq can you just update the branch and solve conflicts? Thank you so much. |
Description
We made lots of danish messages. First iteration was made with llm, then various corrections and improvements were made by danish humans.
Its not 100% but pretty close.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
i18n
What is the current behavior?
Danish translations were english. So english was shown
What is the new behavior?
Danish translations are shown instead.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)