Skip to content

Comments

danish i18n messages#11799

Open
tha-nordiq wants to merge 1 commit intogeosolutions-it:masterfrom
nordiq-group:danish_i18n
Open

danish i18n messages#11799
tha-nordiq wants to merge 1 commit intogeosolutions-it:masterfrom
nordiq-group:danish_i18n

Conversation

@tha-nordiq
Copy link
Contributor

Description

We made lots of danish messages. First iteration was made with llm, then various corrections and improvements were made by danish humans.
Its not 100% but pretty close.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    i18n

What is the current behavior?
Danish translations were english. So english was shown

What is the new behavior?
Danish translations are shown instead.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@tha-nordiq
Copy link
Contributor Author

@tdipisa Hi Tobia
How can i move forward with this one?
I am not seeing the same error locally, and the error does not seem to be related to my commit, unless i misunderstand something?

@tdipisa
Copy link
Member

tdipisa commented Jan 20, 2026

@tha-nordiq I'm sorry for the late answer. Can you please update your PR to the latest master and resolve conflicts please?

@cla-bot
Copy link

cla-bot bot commented Jan 23, 2026

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

@offtherailz offtherailz assigned dsuren1 and unassigned offtherailz Feb 12, 2026
@offtherailz offtherailz requested review from dsuren1 and removed request for offtherailz February 12, 2026 17:35
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tha-nordiq
Kindly align your branch with latest master and resolve conflicts and please grant me write access to your branch nordiq-group:danish_i18n. I would like to push some updates as part of the review. Since the changes are extensive (missing translation keys), it would be difficult to include them directly in the comments, so I plan to add them as a separate commit instead. Once updated, you could review them, and we can proceed further.

Additionally, you will need to sign the CLA in order to contribute.

@offtherailz
Copy link
Member

offtherailz commented Feb 13, 2026

Sorry but recent changes due to CLA and github action checks invalidated your PR 2 times before we had time to merge.
@tha-nordiq of course because you are the danish expert, if you can align the translations files and resolve conflicts, we will take care of taking care of this PR quickly now.

@tdipisa
Copy link
Member

tdipisa commented Feb 13, 2026

@offtherailz thank you. The CLA is signed @tha-nordiq can you just update the branch and solve conflicts? Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants