Skip to content

Conversation

@fbuccioni
Copy link

@fbuccioni fbuccioni commented Feb 9, 2025

I fix a problem on some development web servers that doesn't send the last chunk when in the end bytes range of the request, the value exceeds the size of the file, this problem throws an AggregateError: Request failed, also reported in #218.

To solve it I just implement a small change on src/source/remote.js file.

Thanks for the fantastic library, have a great day.

@fbuccioni fbuccioni changed the title fix: Remote source last slice behavior on last slice fix: Remote source last slice behavior Feb 9, 2025
@fbuccioni
Copy link
Author

Solved linter issues.

@TheMrCam TheMrCam added the bug label May 8, 2025
@TheMrCam TheMrCam added bugfix Fixes a bug and removed bug labels May 21, 2025
@fbuccioni
Copy link
Author

Any news on this, this change will be a relief for many developers. If you want to request a change in code, code styling or any change please tell me and I will do,

@TheMrCam
Copy link
Collaborator

TheMrCam commented Sep 19, 2025

Thank you for your contribution!

Does #474 end up solving the same problem? I could imagine a use case that bypasses the BlockedSource, so if you have examples where that change doesn't remove the AggregateError: Request failed but this PR does, that'd be great to add as a test case! Otherwise I'm probably leaning towards fixing it in the BlockedSource. Upon further reflection, don't believe these are related.

I noticed this other comment that claims that we always have an off-by-one issue here—I'm still investigating, but would you agree based on your own observation or testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants