allow Date.now in schema evaluation (#25223)

set Date.now to a fixed timestamp determined at the beginning of schema evaluation. We do not store this timestamp anywhere; in particular it's not the same timestamp as used for Analyze. But I think that's fine because evaluating the schema really shouldn't be making decisions that change the schema with `Date.now` calls. Basically it's the same as how we treat Math.random in schema evaluation. Note future plan is described in #18861 .

GitOrigin-RevId: 1e8f02217b0383e329f097d036c5e7afa234288c

Author: ldanilek

crates/application/src/application_function_runner/mod.rs

@@ -1688,9 +1688,10 @@ impl<RT: Runtime> ApplicationFunctionRunner<RT> {
         schema_bundle: ModuleSource,
         source_map: Option<SourceMap>,
         rng_seed: [u8; 32],
+        unix_timestamp: UnixTimestamp,
     ) -> anyhow::Result<DatabaseSchema> {
         self.analyze_isolate
-            .evaluate_schema(schema_bundle, source_map, rng_seed)
+            .evaluate_schema(schema_bundle, source_map, rng_seed, unix_timestamp)
             .await
     }
 

crates/application/src/lib.rs

@@ -1469,9 +1469,10 @@ impl<RT: Runtime> Application<RT> {
 
     async fn _evaluate_schema(&self, schema: ModuleConfig) -> anyhow::Result<DatabaseSchema> {
         let rng_seed = self.runtime().with_rng(|rng| rng.gen());
+        let unix_timestamp = self.runtime().unix_timestamp();
         let mut schema = self
             .runner()
-            .evaluate_schema(schema.source, schema.source_map, rng_seed)
+            .evaluate_schema(schema.source, schema.source_map, rng_seed, unix_timestamp)
             .await?;
 
         for table_schema in schema.tables.values_mut() {

crates/isolate/src/client.rs

@@ -428,6 +428,7 @@ pub enum RequestType<RT: Runtime> {
         schema_bundle: ModuleSource,
         source_map: Option<SourceMap>,
         rng_seed: [u8; 32],
+        unix_timestamp: UnixTimestamp,
         response: oneshot::Sender<anyhow::Result<DatabaseSchema>>,
     },
     EvaluateAuthConfig {
@@ -834,12 +835,14 @@ impl<RT: Runtime> IsolateClient<RT> {
         schema_bundle: ModuleSource,
         source_map: Option<SourceMap>,
         rng_seed: [u8; 32],
+        unix_timestamp: UnixTimestamp,
     ) -> anyhow::Result<DatabaseSchema> {
         let (tx, rx) = oneshot::channel();
         let request = RequestType::EvaluateSchema {
             schema_bundle,
             source_map,
             rng_seed,
+            unix_timestamp,
             response: tx,
         };
         self.send_request(Request::new(
@@ -1655,6 +1658,7 @@ impl<RT: Runtime> IsolateWorker<RT> for BackendIsolateWorker<RT> {
                 schema_bundle,
                 source_map,
                 rng_seed,
+                unix_timestamp,
                 response,
             } => {
                 let r = SchemaEnvironment::evaluate_schema(
@@ -1663,6 +1667,7 @@ impl<RT: Runtime> IsolateWorker<RT> for BackendIsolateWorker<RT> {
                     schema_bundle,
                     source_map,
                     rng_seed,
+                    unix_timestamp,
                 )
                 .await;
 

crates/isolate/src/environment/schema.rs

@@ -68,6 +68,7 @@ pub struct SchemaEnvironment {
     schema_bundle: ModuleSource,
     source_map: Option<SourceMap>,
     rng: ChaCha12Rng,
+    unix_timestamp: UnixTimestamp,
 }
 
 impl<RT: Runtime> IsolateEnvironment<RT> for SchemaEnvironment {
@@ -84,10 +85,7 @@ impl<RT: Runtime> IsolateEnvironment<RT> for SchemaEnvironment {
     }
 
     fn unix_timestamp(&self) -> anyhow::Result<UnixTimestamp> {
-        anyhow::bail!(ErrorMetadata::bad_request(
-            "NoDateInSchema",
-            "Date unsupported when evaluating schema"
-        ))
+        Ok(self.unix_timestamp)
     }
 
     fn get_environment_variable(
@@ -181,12 +179,14 @@ impl SchemaEnvironment {
         schema_bundle: ModuleSource,
         source_map: Option<SourceMap>,
         rng_seed: [u8; 32],
+        unix_timestamp: UnixTimestamp,
     ) -> anyhow::Result<DatabaseSchema> {
         let rng = ChaCha12Rng::from_seed(rng_seed);
         let environment = Self {
             schema_bundle,
             source_map,
             rng,
+            unix_timestamp,
         };
         let client_id = Arc::new(client_id);
         let (handle, state) = isolate.start_request(client_id, environment).await?;

crates/isolate/src/tests/schema.rs

@@ -222,11 +222,12 @@ async fn test_eval_schema(rt: TestRuntime) -> anyhow::Result<()> {
 "#;
 
     let rng_seed = rt.with_rng(|rng| rng.gen());
+    let unix_timestamp = rt.unix_timestamp();
     let t = UdfTest::default_with_modules(vec![], rt).await??;
 
     let schema = t
         .isolate
-        .evaluate_schema(source.to_string(), None, rng_seed)
+        .evaluate_schema(source.to_string(), None, rng_seed, unix_timestamp)
         .await?;
 
     let name1: TableName = "noIndexes".parse()?;